Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized values in cellular_automata_global.F90 #24

Closed
climbfuji opened this issue Jun 12, 2020 · 1 comment · Fixed by #27
Closed

Uninitialized values in cellular_automata_global.F90 #24

climbfuji opened this issue Jun 12, 2020 · 1 comment · Fixed by #27

Comments

@climbfuji
Copy link
Collaborator

I found a bug in cellular_automata_global.F90.

For kstep==0, everything is fine.

For kstep>0, the variable "count4", which is used to set the seed in line

call random_setseed(count4,rstate)

is uninitialized. count4 must be initialized properly so that the call above can initialize rstate, which in turn is used to set noise1D.
This was referenced Jul 21, 2020
Merged
Merged
@climbfuji
Copy link
Collaborator Author

Update: a similar bug exists in cellular_automata_sgs.F90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make stochastic physics independent of fv3atm and its submodules climbfuji/stochastic_physics
1 participant
@climbfuji