Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of fv_regional_bc.F90 bug fix #153

Merged

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Update to more recent version of fv_regional_bc.F90

Testing

Extensively tested with authoritative branches, recently retested with RRFS_dev.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel - Jet srun is broken at this moment; baselines were created, but jobs cannot run right now.
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

NOAA-GSL/GFDL_atmos_cubed_sphere#14
NOAA-GSL/fv3atm#159

Copy link

@hu5970 hu5970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change tests/RegressionTests_hera.gnu.log and RegressionTests_hera.intel.log?

@SamuelTrahanNOAA
Copy link
Collaborator Author

Do we need to change tests/RegressionTests_hera.gnu.log and RegressionTests_hera.intel.log?

The code manager will rerun the regression tests and replace the three log files.

@SamuelTrahanNOAA
Copy link
Collaborator Author

I plan on testing your and my PRs at the same time, but I need to know which one goes in first. The second one must contain the first one's changes.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit b63bbbe into NOAA-GSL:RRFS_dev Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants