+Steps to correct Kelvin_initialization issues #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit takes the first steps toward correcting problems with the Kelvin initialization code, including making the OBC nudging timescale an explicit parameter and adding a number of comments identifying concerns and suggesting possible improvements with the code that is used when KELVIN_WAVE_MODE > 0. This commit includes the introduction of the new runtime parameter KELVIN_WAVE_VEL_NUDGING_TIMESCALE, with a default value set to recover the current hard-coded answers. A new warning message cautions about the suspected problems with the internal wave version of the code. By default, all answers are bitwise identical in the 4 Kelvin wave test cases that can be found at github.com/ESMG/ESMG-configs, but there is a new parameter in the MOM_parameter_doc.all files these cases.
|
@kshedstrom, because you originally contributed the user/Kelvin_initialization.F90 code, I would greatly appreciate it if you could examine these changes at your convenience to ensure that you agree with them, and in particular with the comments I have added about the internal Kelvin wave cases and how they might be fixed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #839 +/- ##
============================================
- Coverage 38.11% 38.10% -0.01%
============================================
Files 298 298
Lines 87641 87652 +11
Branches 16417 16422 +5
============================================
+ Hits 33400 33404 +4
- Misses 48223 48225 +2
- Partials 6018 6023 +5 ☔ View full report in Codecov by Sentry. |
|
I approve these changes. Thank you for looking into this problem and providing excellent suggestions in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes the first steps toward correcting problems with the Kelvin initialization code, including making the OBC nudging timescale an explicit parameter and adding a number of comments identifying concerns and suggesting possible improvements with the code that is used when
KELVIN_WAVE_MODE > 0. This commit includes the introduction of the new runtime parameterKELVIN_WAVE_VEL_NUDGING_TIMESCALE, with a default value set to recover the current hard-coded answers. A new warning message cautions about the suspected problems with the internal wave version of the code. By default, all answers are bitwise identical in the 4 Kelvin wave test cases that can be found at github.com/ESMG/ESMG-configs, but there is a new parameter in the MOM_parameter_doc.all files these cases.