+Add Laplacian diffusion of interface heights #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the capability to do Laplacian diffusion of interface heights without regard to the density of layers. This is accomplished by the new internal subroutine add_interface_KH, and is controlled by the new runtime parameters KH_ETA_CONST and KH_ETA_VEL_SCALE. The new interface diffusivities are subject to CFL bounding when combined with the previous isopycnal slope diffusivities, with the two diffusivities reduced proportionately when the CFL limits are exceeded. Also simplified many openMP directives in MOM_thickness_diffuse.F90, and fixed a number of spelling errors or other problems in comments, including adding units to some variables. By default, all answers are bitwise identical, although there are new runtime parameters a new internal subroutine.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #83 +/- ##
============================================
- Coverage 28.97% 28.97% -0.01%
============================================
Files 245 245
Lines 72147 72182 +35
============================================
+ Hits 20907 20914 +7
- Misses 51240 51268 +28
Continue to review full report at Codecov.
|
marshallward
approved these changes
Mar 15, 2022
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14989 ✔️ 🟡 New parameters:
|
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the capability to do Laplacian diffusion of interface heights without
regard to the density of layers. This is accomplished by the new internal
subroutine add_interface_KH, and is controlled by the new runtime parameters
KH_ETA_CONST and KH_ETA_VEL_SCALE. The new interface diffusivities are subject
to CFL bounding when combined with the previous isopycnal slope diffusivities,
with the two diffusivities reduced proportionately when the CFL limits are
exceeded. Also simplified many openMP directives in MOM_thickness_diffuse.F90,
and fixed a number of spelling errors or other problems in comments, including
adding units to some variables. By default, all answers are bitwise identical,
although there are new runtime parameters a new internal subroutine.