Frequency-dependent internal wave drag #815
Conversation
There was a problem hiding this comment.
In addition to the specific comments that I have attached to the relevant lines, we also need to figure out what is causing the doxygen testing to fail before we can accept this PR.
Unfortunately, the doxygen is failing with a segmentation fault and hence is not giving a good error message (see https://github.com/NOAA-GFDL/MOM6/actions/runs/12990322755/job/36293848717?pr=815) . Just based on when doxygen is failing, it appears to be something unusual in a comment in MOM_wave_drag.F90 or MOM_streaming_filter.F90, but I don't have better guidance than this.
888e16e to
d9ee30c
Compare
d9ee30c to
08d91d9
Compare
08d91d9 to
99916d3
Compare
Utilizing streaming band-pass filters, the frequency-dependent wave drag can be applied to the narrowband tidal velocities, instead of the broadband barotropic velocity. This allows internal wave drag to be optimized for different frequency bands independently, without affecting the low-frequency, non-tidal motions. Also fixed the bug that Filt_accum() does not return a valid output if it is called at the corrector step.
Minor performance optimization. Also, this commit allows the filters to be activated without the frequency-dependent drag being activated.
99916d3 to
ed07074
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26405 with the expected warnings about new runtime parameters. |
Utilizing streaming band-pass filters, the frequency-dependent wave drag can be applied to the narrowband tidal velocities, instead of the broadband barotropic velocity. This allows internal wave drag to be optimized for different frequency bands independently, without affecting the low-frequency, non-tidal motions.
Also fixed the bug that Filt_accum() does not return a valid output if it is called at the corrector step.
This is the updated version of PR #722 and is implemented based on the latest code of dev/gfdl.