Merge dev/cpt as of 14 Feb 2022 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em_terms Fix units of *_visc_rem terms
…6nov2021 (*) Merge dev/gfdl as of 06 Nov 2021
Subroutine adjustEtaToFitBathymetry had a hard-wired parameter (hTolerance = 0.1) controlling the tolerance when adjusting the thickness to fit the bathymetry. This patch adds an user-controlled parameter (THICKNESS_TOLERANCE), which replaces hTolerance. THICKNESS_TOLERANCE is only activated when ADJUST_THICKNESS=True.
…d_tolerance2 Remove hard-wired parameter in adjustEtaToFitBathymetry
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #69 +/- ##
============================================
- Coverage 29.00% 29.00% -0.01%
============================================
Files 244 244
Lines 71880 71885 +5
============================================
+ Hits 20851 20852 +1
- Misses 51029 51033 +4
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
This commit is very nice improvement to the code! It has passed the TC testing, and it has passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14806.
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few contribution from dev/cpt that have not been merged yet: