Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument to FMS2 version of get_field_size #64

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

MJHarrison-GFDL
Copy link

@MJHarrison-GFDL MJHarrison-GFDL commented Feb 1, 2022

  • Omitting this argument returns field size using fms1 format, e.g. (Nx,Ny,1,Nt) for data with no vertical extent
    Otherwise, if fms1_format=.false., then return (Nx,Ny,Nt,0)

 - default behavior returns field size using fms1 format.
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #64 (2358142) into dev/gfdl (fc5253f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #64   +/-   ##
=========================================
  Coverage     29.02%   29.02%           
=========================================
  Files           244      244           
  Lines         71854    71854           
=========================================
  Hits          20854    20854           
  Misses        51000    51000           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5253f...2358142. Read the comment docs.

@marshallward
Copy link
Member

I agree with the proposal to remove the fms1_format flag and return a consistent format regardless of backend FMS.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14790 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants