Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h_new needs a halo update before call to remap_OBC_fields in step_MOM_thermo #476

Closed
kshedstrom opened this issue Aug 29, 2023 · 1 comment
Closed

h_new needs a halo update before call to remap_OBC_fields in step_MOM_thermo #476

kshedstrom opened this issue Aug 29, 2023 · 1 comment

Comments

@kshedstrom
Copy link

kshedstrom commented Aug 29, 2023 •
edited
Loading

With the gnu compiler, the halos are full of zeros, but with intel, they have bad values leading to this stack trace:

forrtl: error (65): floating invalid
Image              PC                Routine            Line        Source                  
libpthread-2.31.s  00007F46708248C0  Unknown               Unknown  Unknown
MOM6               0000000000E8F987  mom_remapping_mp_         549  MOM_remapping.F90
MOM6               0000000000E8142F  mom_remapping_mp_         195  MOM_remapping.F90
MOM6               000000000078F741  mom_open_boundary        5541  MOM_open_boundary.F90
MOM6               0000000002322031  mom_mp_step_mom_t        1597  MOM.F90
MOM6               00000000022FE811  mom_mp_step_mom_          812  MOM.F90
MOM6               0000000002D60006  ocean_model_mod_m         594  ocean_model_MOM.F90
MOM6               0000000004BD31D8  MAIN__                   1062  coupler_main.F90
MOM6               00000000004132CD  Unknown               Unknown  Unknown
libc-2.31.so       00007F467050324D  __libc_start_main     Unknown  Unknown
MOM6               00000000004131FA  Unknown               Unknown  Unknown

Note that this section of MOM_open_boundary is just for the tracer reservoirs.
kshedstrom added a commit to ESMG/MOM6 that referenced this issue Aug 29, 2023
@kshedstrom
+Try at fixing issue NOAA-GFDL#476
8b34b44 
- Will change answers for problems with OBCs.
@kshedstrom kshedstrom mentioned this issue Aug 30, 2023
Closed
marshallward pushed a commit that referenced this issue Sep 11, 2023
@MJHarrison-GFDL @marshallward
New TIDAL_SAL_FLATHER option
5b20122 
  - This option is defaulted to False to retain previous answers,
    but should be set to True for new experiments in order to make
    the Flather OBC routine consistent with the barotropic solver

  - This option only applies for regional OBC cases with Tides and
    scalar self-attraction and loading

  + Try at fixing issue #476

    - Will change answers for problems with OBCs.

  - Get Matt's patch to compile again
marshallward pushed a commit that referenced this issue Sep 11, 2023
@MJHarrison-GFDL @marshallward
New TIDAL_SAL_FLATHER option
8a66adc 
  - This option is defaulted to False to retain previous answers,
    but should be set to True for new experiments in order to make
    the Flather OBC routine consistent with the barotropic solver

  - This option only applies for regional OBC cases with Tides and
    scalar self-attraction and loading

  + Try at fixing issue #476

    - Will change answers for problems with OBCs.

  - Get Matt's patch to compile again

Co-authored by: Kate Hedstrom <kshedstrom@alaska.edu>
marshallward pushed a commit that referenced this issue Sep 11, 2023
@MJHarrison-GFDL @kshedstrom @marshallward
New TIDAL_SAL_FLATHER option
9de6ce7 
  - This option is defaulted to False to retain previous answers,
    but should be set to True for new experiments in order to make
    the Flather OBC routine consistent with the barotropic solver

  - This option only applies for regional OBC cases with Tides and
    scalar self-attraction and loading

  + Try at fixing issue #476

    - Will change answers for problems with OBCs.

  - Get Matt's patch to compile again

Co-authored-by: Kate Hedstrom <kshedstrom@alaska.edu>
@marshallward
Copy link
Member

Fixed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kshedstrom @marshallward