Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOM6: Bugfix for mixing up Rho0 and rho_ref in Boussinesq PGF (#837) #511

Merged
merged 1 commit into from
Feb 24, 2025
Merged

MOM6: Bugfix for mixing up Rho0 and rho_ref in Boussinesq PGF (#837) #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions coupled_AM2_LM3_SIS2/AM2_SIS2_MOM6i_1deg/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions coupled_AM2_LM3_SIS2/Concurrent_ice_1deg/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions coupled_AM2_LM3_SIS2/Intersperse_ice_1deg/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/Baltic/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/Baltic_ALE_z_offline_tracers/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,6 +1341,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
TIDES_ANSWER_DATE = 20230630 ! default = 20230630
! The vintage of self-attraction and loading (SAL) and tidal forcing
! calculations. Setting dates before 20230701 recovers old answers (Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/Baltic_OM4_025/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/Baltic_OM4_05/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/OM4_025/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/OM4_05/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/OM_1deg/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/SIS2/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/SIS2_bergs_cgrid/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ice_ocean_SIS2/SIS2_cgrid/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,11 @@ RHO_PGF_REF = 1035.0 ! [kg m-3] default = 1035.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/CVmix_SCM_tests/cooling_only/BML/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,11 @@ RHO_PGF_REF = 1000.0 ! [kg m-3] default = 1000.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/CVmix_SCM_tests/cooling_only/EPBL/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,11 @@ RHO_PGF_REF = 1000.0 ! [kg m-3] default = 1000.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/CVmix_SCM_tests/cooling_only/KPP/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,11 @@ RHO_PGF_REF = 1000.0 ! [kg m-3] default = 1000.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/CVmix_SCM_tests/mech_only/BML/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,11 @@ RHO_PGF_REF = 1000.0 ! [kg m-3] default = 1000.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
5 changes: 5 additions & 0 deletions ocean_only/CVmix_SCM_tests/mech_only/EPBL/MOM_parameter_doc.all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,11 @@ RHO_PGF_REF = 1000.0 ! [kg m-3] default = 1000.0
! The reference density that is subtracted off when calculating pressure
! gradient forces. Its inverse is subtracted off of specific volumes when in
! non-Boussinesq mode. The default is RHO_0.
RHO_PGF_REF_BUG = True ! [Boolean] default = True
! If true, recover a bug that RHO_0 (the mean seawater density in Boussinesq
! mode) and RHO_PGF_REF (the subtracted reference density in finite volume
! pressure gradient forces) are incorrectly interchanged in several instances in
! Boussinesq mode.
SSH_IN_EOS_PRESSURE_FOR_PGF = False ! [Boolean] default = False
! If true, include contributions from the sea surface height in the height-based
! pressure used in the equation of state calculations for the Boussinesq
Expand Down
Loading