Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to run 32BIT MULTI_GASES #37

Closed
wants to merge 36 commits into from
Closed

Fixes to run 32BIT MULTI_GASES #37

wants to merge 36 commits into from

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Apr 28, 2020 •
edited
Loading

To fix the compiling error with 32BIT and MULTI_GASES =Y

Related pull requests
ufs-community/ufs-weather-model#112
NOAA-EMC/fv3atm#108
NCAR/ccpp-physics#444

junwang-noaa and others added 30 commits August 26, 2019 21:03
@junwang-noaa
add option to output omega
96cee64
@junwang-noaa
Merge pull request #1 from junwang-noaa/fv3_omega
97335f0 
This commits vlab ticket #62918: output omega field in fv3 history file
@yangfanglin
VLab Issue #68141
c86c32c 
    modified:   docs/FV3_citations.bib
    modified:   model/fv_cmp.F90

    1) Add an option (namelist parameter: intqs) to use temperature instead of the liquid frozen
    temperature to calculate saturation mixing ratio in deriving GFDLMP PDF cloud cover.
    2) Add a literature reference.
@junwang-noaa
Merge pull request #2 from yangfanglin/gfsv16_physupdt
1f91d39 
    VLab Issue #68141
@yangfanglin
Update fv_cmp.F90 to remove a bug introduced in last update.
bdaaa8d
@DusanJovic-NOAA
change delz from positive value to the original value in the model
700a4f7
@junwang-noaa
Merge pull request NOAA-EMC#4 from NOAA-EMC/gfsv16_physupdt
8dd7628 
gfsv16 physupdt
@pjpegion
Merge pull request #1 from NOAA-EMC/dev/emc
792fe71 
Sync Fork
@climbfuji
Remove TRANSITION mode
eb10b8b
@junwang-noaa
Merge pull request NOAA-EMC#5 from climbfuji/update_master_from_gmtb_…
786447c 
…develop_20191016

Update master from gmtb/develop 2019/10/16
@junwang-noaa
restart reproducibility fix for regional fv3
cc28aa5
@pjpegion
Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cube…
4e2e957 
…d_sphere into dev/emc
@pjpegion
zero out dissipation estimate in halo region, needed for SAR
c4cfedd
@pjpegion
fix of openmp directives for dissipation estimate
b400a5c
@DusanJovic-NOAA
Merge pull request NOAA-EMC#8 from junwang-noaa/regfv3_rst
452333a 
restart reproducibility fix for regional fv3
@junwang-noaa @DusanJovic-NOAA
make writing last restart file optional (NOAA-EMC#9)
0e84f88
@climbfuji @DusanJovic-NOAA
Update dev/emc from dtc/develop: add dynamics code for Ferrier-Aligo …
a56907a 
…microphysics (NOAA-EMC#11)
@jswhit2
add dry mass fixer for IAU (requires change to GFS_typedefs.F90)
c92e0ee
@jswhit2
update - still not quite working
6f5f192
@jswhit2
update 2 - now working
fd00e4a
@jswhit2
remove whitespace changes
a66f3a2
@jswhit2
remove debug prints
d4c2340
@jswhit2
add drymassfixer to IAU_data structure
7a03030
@jswhit2
use area_64 in g_sum call
15abb3d
@jswhit2
add debug prints
0c30161
@jswhit2
remove one debug print
0e30846
@junwang-noaa
add reproduce in g_sum call
da9077d
@junwang-noaa
Merge pull request NOAA-EMC#14 from jswhit2/iau_drymassfixer
db3acfb 
add dry mass fixer for IAU
@pjpegion
Merge pull request #2 from NOAA-EMC/dev/emc
feaf652 
update noaa-psd fork with EMC develop branch
@junwang-noaa
Merge pull request NOAA-EMC#7 from noaa-psd/skeb_sar
371a29a 
Skeb sar
TomBlack-NOAA and others added 6 commits April 8, 2020 09:33
@TomBlack-NOAA
Regional BC blending and BCs into GSI (NOAA-EMC#16)
80ce8ce 
* Add new code for boundary blending and for getting BCs into GSI updates.
@climbfuji
Merge NCAR:dtc/develop into NOAA-EMC:dev/emc
34b4503 
- bugfix for GNU compiler
- reduce noise in stdout

Squashed commit of the following:

commit 86c127f
Merge: ce66d6a f9bbb4f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Fri Apr 10 11:32:21 2020 -0600

    Merge pull request NOAA-EMC#11 from climbfuji/update_dtc_develop_from_dev_emc_20200409

    Update dtc/develop from dev/emc 2020/04/09

commit f9bbb4f
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Thu Apr 9 20:14:24 2020 -0600

    Bugfix for GNU compiler in model/fv_regional_bc.F90, reduce verbosity in driver/fvGFS/atmosphere.F90

commit ecca997
Merge: ce66d6a 80ce8ce
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Thu Apr 9 09:38:48 2020 -0600

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit ce66d6a
Merge: 4279bf7 9bacf55
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Fri Mar 13 13:00:41 2020 -0600

    Merge pull request NOAA-EMC#10 from climbfuji/update_from_dev_emc_20200312_and_other_changes

    Update from dev/emc 2020/03/12

commit 9bacf55
Merge: 4279bf7 371a29a
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Thu Mar 12 10:33:44 2020 -0600

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 4279bf7
Merge: 846f5a5 4858d33
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Mon Mar 9 12:41:51 2020 -0600

    Merge pull request NOAA-EMC#9 from climbfuji/update_dtc_develop_from_emc

    Update dtc/develop from dev/emc 2020/03/04

commit 4858d33
Merge: 846f5a5 db3acfb
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Fri Feb 28 08:46:55 2020 -0700

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 846f5a5
Merge: 3a4dfd8 9a290ee
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Mon Feb 3 07:43:08 2020 -0700

    Merge pull request NOAA-EMC#7 from climbfuji/update_dtc_develop_from_dev-emc

    dtc/develop: update from dev/emc 2020/01/27

commit 9a290ee
Merge: 3a4dfd8 a56907a
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Mon Jan 27 09:28:57 2020 -0700

    Merge branch 'dev/emc' of https://github.com/noaa-emc/GFDL_atmos_cubed_sphere into HEAD

commit 3a4dfd8
Merge: 0c9ab9e 68576a6
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Tue Dec 3 15:19:24 2019 -0700

    Merge pull request NOAA-EMC#6 from climbfuji/dtc_develop_udpate_from_emc_20191127

    dtc/develop: update from EMC 2019/11/27

commit 68576a6
Merge: 0c9ab9e 452333a
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Wed Nov 27 14:13:08 2019 -0700

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 0c9ab9e
Merge: 9871607 b280b37
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Fri Nov 22 16:17:57 2019 -0700

    Merge pull request NOAA-EMC#5 from mzhangw/HAFS_fer_hires

    minimal changes to make nwat =4 compatible with Ferrier-Aligo MP scheme

commit b280b37
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Nov 19 14:53:57 2019 -0700

    bug fix

commit 98c58ad
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Nov 19 14:35:10 2019 -0700

    bug fix

commit 8805acd
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Tue Nov 19 14:16:22 2019 -0700

    From Chunxi: The file fv_mapz.F90 also needs to be modified (K_warm)

commit f8a257a
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 14 19:12:39 2019 -0700

    use upper-case CCPP

commit 77f4fba
Author: Man.Zhang <Man.Zhang@noaa.gov>
Date:   Thu Nov 14 13:40:59 2019 -0700

     implement FA scheme water loading option if nwat =4

commit 9871607
Merge: ed75004 786447c
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Tue Nov 5 06:59:34 2019 +0900

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit ed75004
Merge: 1d6035a f627bfb
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Sat Oct 12 08:45:14 2019 +0900

    Merge pull request NOAA-EMC#4 from climbfuji/update_gmtb_develop_with_vlab_master_20191006

    Update NCAR gmtb/develop with NOAA-EMC dev/emc 2019/10/06

commit f627bfb
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Mon Oct 7 12:12:24 2019 +0900

    Add missing change in fv_cmp.F90 - now identical with EMC code

commit e868186
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date:   Tue Sep 24 01:57:11 2019 +0000

    change delz from positive value to the original value in the model

commit 672eb0e
Author: fanglin.yang <fanglin.yang@noaa.gov>
Date:   Thu Sep 5 19:24:09 2019 +0000

        VLab Issue #68141

        modified:   docs/FV3_citations.bib
        modified:   model/fv_cmp.F90

        1) Add an option (namelist parameter: intqs) to use temperature instead of the liquid frozen
        temperature to calculate saturation mixing ratio in deriving GFDLMP PDF cloud cover.
        2) Add a literature reference.

commit 1d6035a
Merge: 94ab0e1 fec8205
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date:   Mon Sep 23 09:32:55 2019 -0600

    Merge pull request #2 from climbfuji/remove_transition_mode

    Remove TRANSITION mode

commit fec8205
Author: climbfuji <dom.heinzeller@icloud.com>
Date:   Fri Sep 20 08:52:01 2019 -0600

    Remove TRANSITION mode

commit 94ab0e1
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date:   Mon Aug 26 21:03:55 2019 +0000

    add option to output omega

commit b700cae
Author: climbfuji <dom.heinzeller@icloud.com>
Date:   Fri Aug 30 11:58:00 2019 -0600

    model/fv_dynamics.F90: replicating previous change to gmtb/develop branch of FV3, always allocate dtdt_m for IPD version

commit 3df1171
Author: Laurie Carson <carson@ucar.edu>
Date:   Fri Aug 16 10:46:56 2019 -0600

    Add codeowners for NCAR fork
@climbfuji
Delete print statement in driver/fvGFS/atmosphere.F90
ed226dd
@junwang-noaa
Merge pull request NOAA-EMC#17 from climbfuji/update_dev_emc_from_dtc…
38d1f33 
…_develop_20200414

Merge NCAR:dtc/develop into NOAA-EMC:dev/emc 2020/04/14
@climbfuji
Remove CCPP dynamic build from framework (NOAA-EMC#18)
f9d4483
@XiaqiongZhou-NOAA
Fix for multi_gases to 32 bit compiling
7957722
This was referenced Apr 28, 2020
Merged
Merged
Merged
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review April 28, 2020 17:18
@bensonr
Copy link
Contributor

bensonr commented Apr 28, 2020

@XiaqiongZhou-NOAA I think you want this pull request to go to NOAA-EMC::dev/emc first.

@XiaqiongZhou-NOAA
Copy link
Contributor Author

XiaqiongZhou-NOAA commented Apr 28, 2020 via email

@lharris4
Copy link
Contributor

lharris4 commented Apr 28, 2020 via email

@XiaqiongZhou-NOAA
Copy link
Contributor Author

XiaqiongZhou-NOAA commented Apr 28, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Apr 28, 2020 via email

MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
@DusanJovic-NOAA
GFSv16 netcdf post ficein cpl (NOAA-GFDL#48)
7ffe647 
* fv3atm issue NOAA-GFDL#37: fix the real(8) lat/lon in netcdf file
* fv3atm NOAA-GFDL#35: Reducing background vertical diffusivities in the inversion layers
* fv3atm NOAA-GFDL#24: bug in gfsphysics/physics/moninedmf_hafs.f
* fv3atm NOAA-GFDL#18: Optimize netcdf write component and bugfix for post and samfdeepcnv.f
* set (0-1) bounds for ficein_cpl
* remove cache_size due to lower netcdf verion 4.5.1 on mars
* Change ice falling to 0.9 in gfsphysics/physics/gfdl_cloud_microphys.F90
climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024
@bena-nasa
Merge pull request NOAA-GFDL#37 from GEOS-ESM/geos/main
2c6b985 
Pull hotfix into develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@XiaqiongZhou-NOAA @bensonr @lharris4 @junwang-noaa @yangfanglin @DusanJovic-NOAA @pjpegion @climbfuji @jswhit2 @TomBlack-NOAA