Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixed mode support to use in AM5 #354

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

uramirez8707
Copy link
Contributor

Description
Adds mixed mode support for fv3 to be used in AM5 (i.e compile fv3 with r4 and the rest with r8)

The following subroutines were updated to accept r4 and r8 arguments:

  • atmosphere_boundary
  • atmosphere_pref
  • atmosphere_cell_area
  • get_bottom_mass
  • get_bottom_wind
  • get_stock_pe

This was done using the #include method to be consistent with FMS. This was needed because they are called from atmos_drivers.

If compiling with r4, the r4 version of fms constants is used.

Fixes # (issue)

How Has This Been Tested?
AM5 was ran in mixed mode

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Nice use of templating to avoid redundant code.

@laurenchilutti laurenchilutti merged commit f7125f7 into NOAA-GFDL:dev/gfdl_am5 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants