Modern diag manager: check if field is registered #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and uses it to skip fields that were not registered
thomas-robinson
requested changes
Mar 22, 2023
| @@ -255,6 +256,15 @@ logical function fms_diag_files_object_init (files_array) | |||
| endif | |||
| end function fms_diag_files_object_init | |||
|
|
|||
| !< @brief Determine if the field corresponding to the field_id was registered to the file | |||
| !! @return .True. if the field was registed to the file | |||
| logical function is_field_registered(this, field_id) | |||
thomas-robinson
approved these changes
Mar 29, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add a subroutine to check if a field in the file object was registered and uses it to skip fields that were not registered
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add a subroutine to check if a field in the file object was registered and uses it to skip fields that were not registered
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a function to the file_object to check if a field in the file object was registered
Updates
send_diag_completeto skip fields that were not registeredThis was causing out of bounds issues when a variable was not registered since
file_field_ids(ifield)will be -1 soit will try to do
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses