Add ncio to hera and orion lua for enkf_chgres_recenter_nc (#744) #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hera and orion lua files for
enkf_chgres_recenter_ncinmodulefiles/fv3gfsofrelease/gfs.v16.3.0do not load the ncio module. This causesbuild_enkf_chgres_recenter_nc.shto fail when executed bybuild_all.shon hera and orion. This behavior has been documented in g-w issue #744.Type of change
How Has This Been Tested?
The authoritative
release/gfs.v16.3.0was forked to https://github.com/RussTreadon-NOAA/global-workflow. The missingnciolines were added to the hera and orion lua.build_enkf_chgres_recenter_nc.shwas executed on each machine. The build script ran to completion without error. No tests were run to ensure the resulting executable runs correctly.Checklist