Bugfix/coupled crow #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making readme consistant with user.yaml.default
…i cplwav model_config block. Reinstating config.wave block in JGLOBAL_FORECAST. Pointing EXECwave to HOMEgfs/exec directory for WW3 util executables (changed link_fv3gfs.sh accordingly). Removing debug options from compile.sh line in build_fv3.sh.
…coupled-crow-addWW3jobs
move default value into defaults/
It's better if we have one place to manage default values for configurable variables other than two Default values only for reference. Please throughly test to make sure it could reproduce.
default field table change to match current selection
scripts update: CCPP and IPD works
add hard-coded variables into config.fcst (fcst.yaml)
ice variable istep0 bug fix
add FNMSKH conditional clause, coupled vs non-coupled
…ripts Conflicts: workflow/platforms/_sandbox.yaml
…to bugfix/coupled-crow
|
(1) ocnpost failed, you need to define ncks in config.base |
…t does updating model to latest tag
|
@jiandewang would you please test this PR once again on Orion? |
updated README
|
I think for the ocean post to work, we need all the updates that are in my branch here: https://github.com/JessicaMeixner-NOAA/global-workflow/tree/s2s_prototype4 |
|
Ok I will do that
On Wed, Jul 15, 2020 at 9:11 AM JianKuang-NOAA ***@***.***> wrote:
@jiandewang <https://github.com/jiandewang> would you please test this PR
once again on Orion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGAS3D4OXGV5ZGJMX5CFDR3WTGXANCNFSM4ONRUSOA>
.
--
Jiande Wang
IMSG at NOAA/NWS/NCEP/EMC
cubic 2088
jiande.wang@noaa.gov
phone:3016833725
|
|
@JessicaMeixner-NOAA I will merge it in. |
|
@JianKuang-NOAA that branch is not ready to be merged into the feature/coupled-crow branch yet |
|
build_reg2grb2.sh failed in compiling:
use wgrib2api
----^
regdiag.f(52): error #7002: Error in opening the compiled module file.
Check INCLUDE paths. [WGRIB2API]
use wgrib2api
----^
regdiag.f(453): error #6404: This name does not have a type, and must have
an explicit type. [GRB2_MK_INV]
iret = grb2_mk_inv(template_file, template_inv)
…On Wed, Jul 15, 2020 at 9:11 AM JianKuang-NOAA ***@***.***> wrote:
@jiandewang <https://github.com/jiandewang> would you please test this PR
once again on Orion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGAS3D4OXGV5ZGJMX5CFDR3WTGXANCNFSM4ONRUSOA>
.
--
Jiande Wang
IMSG at NOAA/NWS/NCEP/EMC
cubic 2088
jiande.wang@noaa.gov
phone:3016833725
|
|
@JianKuang-NOAA I said that the branch was not ready to be merged into feature/coupled-crow, so why was it merged into this PR? In addition - the comment I made about cplwav still needs to be addressed |
|
@JessicaMeixner-NOAA Sorry I overlooked your previous comment. I will re-draft this PR. |
lgannoaa
pushed a commit
to lgannoaa/global-workflow
that referenced
this pull request
Feb 9, 2022
* Initial spack/cmake version * updated for umbrella build * tweak to findnetcdf * added include directory * updated cmake * changed to https for cmake submodule * updated cmake submodule * updated install directory * added build for libnceppost.a * modifications for macOS clang/gfortran build * updated for gnu build * udpated cmake submodule * Add RST file for UPP v4.0 * Modifying introduction * merged develop in and separated library from executable in build * Update CMakeLists.txt files to support GNU compilers * applied patch from Dusan * Add conf.py for upp documentation * Add index.rst for upp documentation * Add readthedocs config file * Modify name of main rst doc in index for readthedocs build test * Change master file to index * Edits for UFS documentation to remove WRF and grib1 references * Add a readthedocs config file * Mods to config and index files for use in readthedocs * Update submodule pointer for cmake * Remove old GNU makefiles with problematic names (only differing in case from existing files) * Add files for GRIB2 table of fields * Update .gitmodules, add branch = ufs_release_1.0 for cmake * Update .gitmodules for testing, code review and merging * Update include/lib flags for sigio, sfcio, nemsio * Add REQUIRED attribute to find_package calls in CMakeLists.txt * Comment out LAPACK dependency in CMakeLists.txt * Revert change to .gitmodules, update submodule pointer for cmake * sorc/ncep_post.fd/CMakeLists.txt: change GFSIO_INC to GFSIO_INC4 * Add capacity of detecting scaning mode north2south vs south2north in gaussian grid from Dusan. * Re-factor CMake * Fix library linking * small fix to kyles refactor * Add capacity of detecting scaning mode north2south vs south2north in gaussian grid from Dusan. * Fix typo in sorc/ncep_post.fd/CMakeLists.txt * Fix how Intel compile options with spaces in them are handled * Update branch name for cmake submodule, update submodule pointer * Update submodule pointer for cmake * Update .gitmodules and submodule pointer for cmake, bugfixes for CMakeLists.txt * Update submodule pointer for cmake * fixes problem linking ncep_post with gnu/openmpi * Update submodule pointer for cmake * Revert .gitmodules change * Bugfix: comment out debug print statement that can lead to out-of-bounds access; update submodule pointer for cmake * Update submodule pointer for cmake * OpenMP bugfix, use lowercase in find_package(CRTM) * Fix post crash on macOS: use allocatable array * Update submodule pointer for cmake * Add UFS UPP rst documentation * Update submodule pointer for cmake * Rename g2tmpl_d to g2tmpl (NOAA-EMC#89) * Update submodule pointer for cmake * cleanup post Change-Id: Ie52af5ff79ac4122e79d7a46e89ee2077188b0a4 * we dont depend on C HDF5 library. remove. Change-Id: I26aa7c0bf7ed2783de1a9967d961d0260dee8b54 * use transitive properties. apply OpenMP flags if OpenMP is found. Formatting using cmake-format Change-Id: Ic08ce6bc85a7d949c779ec597241c8cb4c20db86 * add debug gnu flags. compile_definitions does not like the quotes around long long, remove Change-Id: Iccd5bb496944f75a79500729051dd571303cb50f * Update CMakeLists.txt * Update submodule pointer for cmake * Update submodule pointer for cmake * Add LGPL license to repository * EMC_post is a Fortran only project. blockIO.c is not used, so do not include in building * Update submodule pointer for cmake * Bug fix for unary operator in INITPOST_GFS_NEMS_MPIIO.f. (NOAA-EMC#92) * Remove old unused makefiles * CMakeLists.txt: install postxconfig-NT-GFS-F00.txt and postxconfig-NT-GFS.txt in share directory * Update version @fossell says post is at version 8.0.0 * Update submodule pointer for cmake * Fix Out of Bound Exception in GFSPOST.F (NOAA-EMC#100) * Fix out-of-bound error in tpause routine in GFSPOST.F * Fix use of undefined variables. * Feature/cleanup (NOAA-EMC#95) * cleanup post Change-Id: Ie52af5ff79ac4122e79d7a46e89ee2077188b0a4 * we dont depend on C HDF5 library. remove. Change-Id: I26aa7c0bf7ed2783de1a9967d961d0260dee8b54 * use transitive properties. apply OpenMP flags if OpenMP is found. Formatting using cmake-format Change-Id: Ic08ce6bc85a7d949c779ec597241c8cb4c20db86 * add debug gnu flags. compile_definitions does not like the quotes around long long, remove Change-Id: Iccd5bb496944f75a79500729051dd571303cb50f * Update CMakeLists.txt * EMC_post is a Fortran only project. blockIO.c is not used, so do not include in building * Update version @fossell says post is at version 8.0.0 * Revert "Feature/cleanup (NOAA-EMC#95)" This reverts commit 7e9797b355d2b86ea9e274534f86adc42e866b95. * remove unused compile definitions and update cmake pointer Change-Id: Ie47cf16ebc25928bf30bfd05d4f25678219571a6 * Fix ID index in WRF-CHEM SMOKE block, which currently causes failed build in debug mode * remove unnecessary commented line * NetCDF static fix (#1) * CMakeLists.txt: add MODULE to find_package calls * Cleanup of NetCDF in CMakeLists.txt * update cmake submodule pointer Change-Id: I763882fd6ecc4b8cc64a60eddabccfdb7046040d * Add MODULE to find_package(NetCDF) call (NOAA-EMC#3) * update cmake submodule pointer Change-Id: I69015efa425658645567e9d9f22d5e51301c1a0b * Change version from 8.0.0 to 1.0.0 * fix the install path of compiled Fortran module files Co-authored-by: Mark A Potts <mark.potts@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com> Co-authored-by: Tracy <hertneky@ucar.edu> Co-authored-by: Kate Fossell <fossell@ucar.edu> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Wen Meng <wen.meng@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Kyle Gerheiser <kgerheiser@icloud.com> Co-authored-by: Mark Potts <mpotts@redlineperf.com> Co-authored-by: Kyle Gerheiser <3209794+kgerheiser@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov> Co-authored-by: Tracy <tracy.hertneky@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com> Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
TerrenceMcGuinness-NOAA
added a commit
that referenced
this pull request
Jun 8, 2023
Update testhera.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed some bugs causing an error when running uncoupled case using feature/coupled-crow branch.
Moved the determination of "cpl" to defaults/settings from config/base.yaml
Please test on Hera and other supported platforms to see if both coupled and uncoupled case could be generated successfully.
One could create an uncoupled case by changing "cplflx" to "false" in the case file.