-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nceplibs-ncio for enkf_chgres_recenter_nc utility #839
Conversation
…y updated for WCOSS2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. They will allow the enkf_chgres_recenter_nc utility to build on WCOSS2 following the removal of fv3gfs_ncio from the GSI repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks @aerorahul !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Has anyone built and run enkf_chgres_recenter_nc.x
from feature/update_ncio
to ensure that it generates b4b identical results with the control (WCOSS2 operations)? It should, but have we confirmed this?
No @RussTreadon-NOAA. |
@aerorahul , valid point. "Run a test to confirm b4b identical results" is easy to say, not so easy to do. One could stage data in a production look-alike directory structure to run |
Is it ok to merge this or are we waiting for a test confirmation? |
Testing is tedious. Perhaps an after-the-fact test may be run after this PR is closed. When the GFS v16.3.0 parallel begins take a cycle and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enkf_chgres_recenter_nc.x
is built with the nceplibs-ncio
.
Description
This PR:
fv3gfs_ncio
and usesnceplibs-ncio
.This fix is needed for gfsv16.3.0
Type of change
How Has This Been Tested?
enkf_chgres_recenter_nc
on WCOSS2Checklist