Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use latest code for feature/coupled-crow #402

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

This PR updates the ufs-weather-model hash to use the commit from 8/10/21 9bbb6d4 as this has needed bugfixes for Prototype 7.

This PR updates a few namelist options that were required to run with the newest model and cleaned up a few variables that are no longer used in model_configure. Lastly, there were a few namelist changes that were previously missed as we were preparing for Prototype 7.

@JessicaMeixner-NOAA
Copy link
Contributor Author

A test using these updates can be found here:

COM: /scratch2/NCEPDEV/climate/Jessica.Meixner/p7update/test01/COM/test01/gfs.20130401/00
Rundir: /scratch2/NCEPDEV/climate/Jessica.Meixner/p7update/test01/DATA/test01/2013040100/gfs/fcst.300344

@JessicaMeixner-NOAA
Copy link
Contributor Author

The case file aerosol_free_forecast.yaml is currently being run to determine if anything breaks for GOCART runs.

@JessicaMeixner-NOAA
Copy link
Contributor Author

The model failed with:
forrtl: severe (174): SIGSEGV, segmentation fault occurred
Image PC Routine Line Source
ufs_model 000000000431C89C Unknown Unknown Unknown
libpthread-2.17.s 00002B30035CD630 Unknown Unknown Unknown
ufs_model 0000000003914E8A gfdl_cloud_microp 3935 module_gfdl_cloud_microphys.F90
ufs_model 0000000003918782 gfdl_cloud_microp 2158 module_gfdl_cloud_microphys.F90
ufs_model 000000000391768F gfdl_cloud_microp 2030 module_gfdl_cloud_microphys.F90
ufs_model 0000000003909CFD gfdl_cloud_microp 996 module_gfdl_cloud_microphys.F90
ufs_model 00000000039034D9 gfdl_cloud_microp 495 module_gfdl_cloud_microphys.F90
ufs_model 00000000038E129D gfdl_cloud_microp 238 gfdl_cloud_microphys.F90
ufs_model 00000000037C624B ccpp_fv3_gfs_v16_ 1754 ccpp_FV3_GFS_v16_ugwpv1_physics_cap.F90
ufs_model 000000000365A138 ccpp_static_api_m 432 ccpp_static_api.F90
ufs_model 00000000036583E1 ccpp_driver_mp_cc 188 CCPP_driver.F90

Log file: /scratch2/NCEPDEV/climate/Jessica.Meixner/p7update/gocart01/COMROOT/gocart01/logs/2013040100/gfs.forecast.highres.log

@rmontuoro do you expect the case file aerosol_free_forecast.yaml to run with ufs-weather-model hash: 9bbb6d4
or will we need to wait for your PR tomorrow? @WalterKolczynski-NOAA wants to make sure we do not break GOCART features, but we need this PR to start running P7c first 8 cases. I don't believe this segfault is related to the restart interval which is why this test was run initially.

@rmontuoro
Copy link

@JessicaMeixner-NOAA - I'd expect the case to run if you build the ufs-weather-model using -DAPP=ATMAERO.

In any case, I'd suggest not to delay this update if the issues you see are localized to aerosols. We are now using a fork of global-workflow to run our early verification cases. Hopefully our updates can be brought in once all ufs-weather-model PRs have been merged.

@JessicaMeixner-NOAA
Copy link
Contributor Author

@rmontuoro I did:
"sh build_all.sh -a"
when I got that error. Thanks for understanding about needing to move this forward. If I can help debug why this isn't working (or when you have the PRs for the rest in) please let me know. I do not want to break that functionality but also want to be able to start with p7c.

@WalterKolczynski-NOAA
Copy link
Contributor

@rmontuoro I did:
"sh build_all.sh -a"
when I got that error. Thanks for understanding about needing to move this forward. If I can help debug why this isn't working (or when you have the PRs for the rest in) please let me know. I do not want to break that functionality but also want to be able to start with p7c.

I can take care of any issues with aerosols. It built fine for me on Hera, but we can take any further talk about the problem elsewhere.

@JessicaMeixner-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA it builds on hera for me too, it does not run w/out segfaulting though

@WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA it builds on hera for me too, it does not run w/out segfaulting though

Okay, that's where I got to as well. I misunderstood you're findings I'll work it out with @rmontuoro if need be, but this PR can go through.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit d53b297 into NOAA-EMC:feature/coupled-crow Aug 11, 2021
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the coupled/cleanup branch August 12, 2021 13:00
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this pull request Feb 9, 2022
* Created formal fortran namelist for itag.

* This is a legacy script. No updates are needed.

* Further code refinement from Wen.

* Added a change log.

* Replace replace "fullmodelname" with "modelname,
submodelname" in "model_inputs".

* bug fix

* Replace FULLMODELNAME to MODELNAME.

* Further clean up for FULLMODELNAME.

* Further code refinement from Wen.

* Rename control file variable name.

* Removed fileNameFlat in gfs itag.

* Further code refinement from Wen.
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
…OAA-EMC#402)

Substantial changes in UGWPv1 to fix problem of lack of reproducibility when changing the domain decomposition layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants