Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the empty aerosol DA aerostat tar file issue #3332

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

CoryMartin-NOAA
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Feb 14, 2025

Somewhere along the way, an inconsistency between the aerosol DA diagnostic file output name suffixes and the workflow crept in, where the files were generated, but not found via glob and put in a tarball because of .nc vs .nc4. This PR resolves this issue plus also renames the file to be more descriptive, e.g.:
gdas.t00z.aerostat.tgz
to clarify it is a tar ball with gzip. The PR also makes it a tarball with gzip instead of an uncompressed tar.

Resolves #3327

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Example:

  • Clone and build on Hera
  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aerorahul aerorahul merged commit 0da3832 into NOAA-EMC:develop Feb 14, 2025
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/aerostat branch February 14, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aerosol DA diag files not being tarred properly
2 participants