Add missing file safeguard for IMS prep in snow analysis tasks #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov>
Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov>
jiaruidong2017
previously approved these changes
Feb 14, 2025
aerorahul
reviewed
Feb 14, 2025
| @@ -178,7 +178,7 @@ def prepare_IMS(self) -> None: | |||
|
|
|||
| asc_file = os.path.join(localconf.COMIN_OBS, f"{localconf.OPREFIX}imssnow96.asc") | |||
| if not os.path.isfile(asc_file): | |||
| logger.exception(f"Obs files are missing. Will not execute CALCFIMSEXE") | |||
| logger.warn(f"WARNING: Obs files are missing. Will not execute CALCFIMSEXE") | |||
There was a problem hiding this comment.
Suggested change
| logger.warn(f"WARNING: Obs files are missing. Will not execute CALCFIMSEXE") | |
| logger.warning(f"WARNING: Obs files {asc_file} is missing. Will not execute CALCFIMSEXE") |
same below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a safeguard to only continue running the IMS prep step in the snow analysis tasks if the necessary obs file is present.
Resolves #3328
Type of change
Change characteristics
How has this been tested?
2.5 cycle experiment on Hera
Checklist