Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting up the archive task #3242

Merged

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Jan 21, 2025

Description

  • In this PR the archive task will be split into two parts. The first will always run and will just be for the copying of verification data to the VRFY_ARC and ARCDIR directories. The second will only run when HPSSARCH or LOCALARCH is set to YES and will generate and store tarballs in the ATARDIR, either on HPSS or locally.

  • Resolves Split up the archive task #3152

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • CI tests in Hera

Example:

  • Cycled test on Hera
  • Forecast-only on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@DavidHuber-NOAA
Copy link
Contributor

The gfs_arch_tars job failed for the C96_atm3DVar test on Hera twice due to log file sizes changing during execution of htar. The first failure was for the log file gfs_arch_vrfy.log and the second for gfs_metpg2g1.log.

First, the parm/archive/gfsa.yaml.j2 file needs to be amended here

{% if not "gfs_arch.log" in log %}

to screen out gfs_arch_tars.log instead of gfs_arch.log.

Next, I think the dependencies need to be reworked for the gfs_arch_tars job so that it runs after gfs_arch_vrfy and the gfs_metp metatask. I could be convinced that the gfs_metp* tasks do not need to run before gfs_arch_tars, but then the screening in gfsa.yaml.j2 will need to also exclude gfs_metp*.log files.

@AntonMFernando-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA @DavidHuber-NOAA C96_atm3DVar test passed with new changes.
test: /scratch1/NCEPDEV/global/Anton.Fernando/RUNTESTS/EXPDIR/gefs_C96_atm3DVar

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending CI testing. One question regarding runtime of arch_vrfy.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 30, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Jan 30, 2025
@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 30, 2025
@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 30, 2025
@emcbot
Copy link

emcbot commented Jan 30, 2025

CI Passed on Hera in Build# 5
Built and ran in directory /scratch1/NCEPDEV/global/CI/3242


Experiment C96_S2SWA_gefs_replay_ics_541286b8 Completed 1 Cycles: *SUCCESS* at Thu Jan 30 18:21:07 UTC 2025
Experiment C48_ATM_541286b8 Completed 1 Cycles: *SUCCESS* at Thu Jan 30 18:27:03 UTC 2025
Experiment C48mx500_hybAOWCDA_541286b8 Completed 2 Cycles: *SUCCESS* at Thu Jan 30 18:33:14 UTC 2025
Experiment C48_S2SW_541286b8 Completed 1 Cycles: *SUCCESS* at Thu Jan 30 19:58:51 UTC 2025
Experiment C96C48_hybatmDA_541286b8 Completed 3 Cycles: *SUCCESS* at Thu Jan 30 20:47:49 UTC 2025
Experiment C96_atm3DVar_541286b8 Completed 3 Cycles: *SUCCESS* at Thu Jan 30 21:05:59 UTC 2025
Experiment C96C48_hybatmaerosnowDA_541286b8 Completed 3 Cycles: *SUCCESS* at Thu Jan 30 21:06:29 UTC 2025
Experiment C96C48_ufs_hybatmDA_541286b8 Completed 3 Cycles: *SUCCESS* at Thu Jan 30 21:48:56 UTC 2025
Experiment C48_S2SWA_gefs_541286b8 Completed 1 Cycles: *SUCCESS* at Thu Jan 30 21:50:25 UTC 2025
Experiment C48mx500_3DVarAOWCDA_541286b8 Completed 2 Cycles: *SUCCESS* at Thu Jan 30 22:14:03 UTC 2025

@DavidHuber-NOAA
Copy link
Contributor

@AntonMFernando-NOAA All tests passed on Hera. I don't think we need to do a full test on WCOSS2, but the C96_atm3Dvar_extended test should be run there with HPSSARCH=YES to ensure that all tarballs are generated as intended.

@DavidHuber-NOAA
Copy link
Contributor

@AntonMFernando-NOAA does not have rstprod access on WCOSS2 yet, so I will run the C96_atm3Dvar_extended case on Cactus.

@DavidHuber-NOAA
Copy link
Contributor

@AntonMFernando-NOAA The extended test gfs_arch_tars job failed on the second full cycle (2021122106) because it launched before all of the gempak jobs finished. These should be added as dependencies for the arch_tars job task. I will make a suggested change shortly.

@DavidHuber-NOAA
Copy link
Contributor

Actually, I think this should be handled in another issue since it existed before this PR and will require additional testing. I will open that now.

Also, I reran the gfs_arch_tars job manually after the gempak jobs finished. All tarballs were created successfully. Marking this PR as having successfully passed WCOSS2 CI testing.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully label Feb 3, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit c9011ab into NOAA-EMC:develop Feb 3, 2025
6 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA mentioned this pull request Feb 12, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up the archive task
4 participants