From d0737cdba81cc1bed460935316949dd7ec7b137f Mon Sep 17 00:00:00 2001 From: "catherine.thomas" Date: Thu, 14 Mar 2024 15:44:13 -0400 Subject: [PATCH 1/2] Fix ensemble archive groups to include all members The number of groups used in the ensemble archive step (earc) needs to include a task for the ensemble stat files such as the mean and the spread, resulting in n_groups+1 tasks for earc. Refs: #2390 --- workflow/rocoto/gfs_tasks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow/rocoto/gfs_tasks.py b/workflow/rocoto/gfs_tasks.py index b91e974c74..7965bc4592 100644 --- a/workflow/rocoto/gfs_tasks.py +++ b/workflow/rocoto/gfs_tasks.py @@ -2661,7 +2661,7 @@ def earc(self): # Integer division is floor division, but we need ceiling division n_groups = -(self.nmem // -self._configs['earc']['NMEM_EARCGRP']) - groups = ' '.join([f'{grp:02d}' for grp in range(0, n_groups)]) + groups = ' '.join([f'{grp:02d}' for grp in range(0, n_groups+1)]) cycledef = 'gdas_half,gdas' if self.cdump in ['enkfgdas'] else self.cdump.replace('enkf', '') From 8f14a4d534523821f236131a6ce87e0d779d7ed9 Mon Sep 17 00:00:00 2001 From: CatherineThomas-NOAA <59020064+CatherineThomas-NOAA@users.noreply.github.com> Date: Fri, 15 Mar 2024 08:13:48 -0400 Subject: [PATCH 2/2] Update format for PEP-8 compliance (#2390) Co-authored-by: Walter Kolczynski - NOAA --- workflow/rocoto/gfs_tasks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workflow/rocoto/gfs_tasks.py b/workflow/rocoto/gfs_tasks.py index 7965bc4592..36b57bd6dc 100644 --- a/workflow/rocoto/gfs_tasks.py +++ b/workflow/rocoto/gfs_tasks.py @@ -2661,7 +2661,7 @@ def earc(self): # Integer division is floor division, but we need ceiling division n_groups = -(self.nmem // -self._configs['earc']['NMEM_EARCGRP']) - groups = ' '.join([f'{grp:02d}' for grp in range(0, n_groups+1)]) + groups = ' '.join([f'{grp:02d}' for grp in range(0, n_groups + 1)]) cycledef = 'gdas_half,gdas' if self.cdump in ['enkfgdas'] else self.cdump.replace('enkf', '')