Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerosol DA diag files not being tarred properly #3327

Closed
CoryMartin-NOAA opened this issue Feb 14, 2025 · 1 comment · Fixed by #3332
Closed

Aerosol DA diag files not being tarred properly #3327

CoryMartin-NOAA opened this issue Feb 14, 2025 · 1 comment · Fixed by #3332
Labels
bug Something isn't working JEDI Feature development to support JEDI-based DA triage Issues that are triage

Comments

@CoryMartin-NOAA
Copy link
Contributor

What is wrong?

Tarball is empty, due to the wrong netCDF file suffix being used

What should have happened?

Files in tarballs!

What machines are impacted?

All or N/A

What global-workflow hash are you using?

develop

Steps to reproduce

run aerosol DA
...
look at gdas.t??z.aerostat

Additional information

No response

Do you have a proposed solution?

Yes, will fix, also will take this opportunity to rename it from aerostat to aerostat.tgz

@CoryMartin-NOAA CoryMartin-NOAA added bug Something isn't working triage Issues that are triage labels Feb 14, 2025
@CoryMartin-NOAA CoryMartin-NOAA added the JEDI Feature development to support JEDI-based DA label Feb 14, 2025
@aerorahul
Copy link
Contributor

closed via #3332

aerorahul pushed a commit that referenced this issue Feb 14, 2025
Somewhere along the way, an inconsistency between the aerosol DA
diagnostic file output name suffixes and the workflow crept in, where
the files were generated, but not found via glob and put in a tarball
because of `.nc` vs `.nc4`. This PR resolves this issue plus also
renames the file to be more descriptive, e.g.:
`gdas.t00z.aerostat.tgz`
to clarify it is a tar ball with gzip. The PR also makes it a tarball
with gzip instead of an uncompressed tar.

  Resolves #3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JEDI Feature development to support JEDI-based DA triage Issues that are triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants