From 137850bf35dac200c1be5bc9f6783c4fdd7615af Mon Sep 17 00:00:00 2001 From: Dusan Jovic Date: Thu, 16 Jun 2022 17:58:11 +0000 Subject: [PATCH 1/5] Update .gitmodules --- .gitmodules | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 6bb663df1..a493a6b75 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,7 +1,9 @@ [submodule "atmos_cubed_sphere"] path = atmos_cubed_sphere - url = https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere - branch = dev/emc + #url = https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere + #branch = dev/emc + url = https://github.com/DusanJovic-NOAA/GFDL_atmos_cubed_sphere + branch = missing_value_r4 [submodule "ccpp/framework"] path = ccpp/framework url = https://github.com/NCAR/ccpp-framework From 491958320ea9a7efcf75b474e9e06fb7bfe8594f Mon Sep 17 00:00:00 2001 From: Dusan Jovic Date: Thu, 16 Jun 2022 18:05:56 +0000 Subject: [PATCH 2/5] Use 32bit value for 'missing_value' and '_FillValue' attributes --- atmos_cubed_sphere | 2 +- io/FV3GFS_io.F90 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/atmos_cubed_sphere b/atmos_cubed_sphere index fad4c9f1f..752c6705b 160000 --- a/atmos_cubed_sphere +++ b/atmos_cubed_sphere @@ -1 +1 @@ -Subproject commit fad4c9f1fc29c0cbb47df9a07a573249155a1c42 +Subproject commit 752c6705bc85cf74755e08752ed59f00a4c1843f diff --git a/io/FV3GFS_io.F90 b/io/FV3GFS_io.F90 index ef7cbf008..1c3738238 100644 --- a/io/FV3GFS_io.F90 +++ b/io/FV3GFS_io.F90 @@ -3640,7 +3640,7 @@ subroutine add_field_to_phybundle(var_name,long_name,units,cell_methods, axes,ph line=__LINE__, file=__FILE__)) call ESMF_Finalize(endflag=ESMF_END_ABORT) call ESMF_AttributeSet(field, convention="NetCDF", purpose="FV3", & - name='missing_value',value=missing_value,rc=rc) + name='missing_value',value=real(missing_value,kind=4),rc=rc) if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, & line=__LINE__, file=__FILE__)) call ESMF_Finalize(endflag=ESMF_END_ABORT) @@ -3650,7 +3650,7 @@ subroutine add_field_to_phybundle(var_name,long_name,units,cell_methods, axes,ph line=__LINE__, file=__FILE__)) call ESMF_Finalize(endflag=ESMF_END_ABORT) call ESMF_AttributeSet(field, convention="NetCDF", purpose="FV3", & - name='_FillValue',value=missing_value,rc=rc) + name='_FillValue',value=real(missing_value,kind=4),rc=rc) if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, & line=__LINE__, file=__FILE__)) call ESMF_Finalize(endflag=ESMF_END_ABORT) From 4d15ea2d0cf4f688e8d2edc8a0969a41f9465b2c Mon Sep 17 00:00:00 2001 From: Dusan Jovic Date: Wed, 3 Aug 2022 15:19:18 +0000 Subject: [PATCH 3/5] update atmos_cubed_sphere --- atmos_cubed_sphere | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atmos_cubed_sphere b/atmos_cubed_sphere index 752c6705b..36dd929bd 160000 --- a/atmos_cubed_sphere +++ b/atmos_cubed_sphere @@ -1 +1 @@ -Subproject commit 752c6705bc85cf74755e08752ed59f00a4c1843f +Subproject commit 36dd929bdd7b0d3e51b237be51db5adb17a65fac From 5ce2b03fa8efe5b0182c3960a206efe4ed4a0152 Mon Sep 17 00:00:00 2001 From: Dusan Jovic Date: Wed, 28 Dec 2022 21:08:34 +0000 Subject: [PATCH 4/5] Update atmos_cubed_sphere --- atmos_cubed_sphere | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atmos_cubed_sphere b/atmos_cubed_sphere index 36dd929bd..a5d502c7f 160000 --- a/atmos_cubed_sphere +++ b/atmos_cubed_sphere @@ -1 +1 @@ -Subproject commit 36dd929bdd7b0d3e51b237be51db5adb17a65fac +Subproject commit a5d502c7fb9fd39ddce6821d3d03406121b19483 From ca09489399c0ddbc34bb97b96fa4c4415615ffb1 Mon Sep 17 00:00:00 2001 From: Dusan Jovic Date: Wed, 25 Jan 2023 14:31:20 +0000 Subject: [PATCH 5/5] Update atmos_cubed_sphere and revert .gitmodules --- .gitmodules | 6 ++---- atmos_cubed_sphere | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.gitmodules b/.gitmodules index a2adaec48..22c723ac1 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,9 +1,7 @@ [submodule "atmos_cubed_sphere"] path = atmos_cubed_sphere - #url = https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere - #branch = dev/emc - url = https://github.com/DusanJovic-NOAA/GFDL_atmos_cubed_sphere - branch = missing_value_r4 + url = https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere + branch = dev/emc [submodule "ccpp/framework"] path = ccpp/framework url = https://github.com/NCAR/ccpp-framework diff --git a/atmos_cubed_sphere b/atmos_cubed_sphere index a5d502c7f..3f7b57a28 160000 --- a/atmos_cubed_sphere +++ b/atmos_cubed_sphere @@ -1 +1 @@ -Subproject commit a5d502c7fb9fd39ddce6821d3d03406121b19483 +Subproject commit 3f7b57a28b334c7f2485b26c29f1d5b9f3c1cd7d