Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize ungridded dimensions for the partitioned stokes drift between WW3 and MOM6 #863

Conversation

DeniseWorthen
Copy link
Contributor

Pull Request Summary

Enables field exchanges for partitioned stokes drift using ungridded dimensions with the WW3 mesh cap

Description

Removes the 6 fields associated with partitioned stokes drift export within the dev/ufs-weather-model mesh cap in favor of 2 fields with 3 ungridded dimesions each.

Issue(s) addressed

UWM Issue #1526

Commit Message

Enables field exchanges for partitioned stokes drift using ungridded dimensions with the WW3 mesh cap

Check list

Testing

See UWM PR #1527 for testing details.

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@MatthewMasarik-NOAA
Copy link
Collaborator

Hi @DeniseWorthen, just a note to say our CI cache got emptied and as a result our check-in builds are failing. We are pausing PR evaluations until this CI issue is resolved. The commit queue has been updated to reflect this. We're working to get this resolved ASAP and will keep you posted. Thank you for your patience.

@DeniseWorthen
Copy link
Contributor Author

Thanks for the update.

@JessicaMeixner-NOAA
Copy link
Collaborator

@DeniseWorthen the CI issues should now be fixed in develop. The issues will likely linger on dev/ufs-weather-model until an upcoming merge by @MatthewMasarik-NOAA or myself with all recent develop changes to dev/ufs-weather-model.

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates to the cap code are approved.

@MatthewMasarik-NOAA
Copy link
Collaborator

@DeniseWorthen an update on scheduling, we won't merge develop into dev/ufs-weather-model until after Jan 3rd.

@MatthewMasarik-NOAA
Copy link
Collaborator

@DeniseWorthen @jkbk2004 I apologize, I dropped the ball here. I'm working to have this set as soon as I can for the next opportunity.

@DeniseWorthen
Copy link
Contributor Author

@MatthewMasarik-NOAA Testing is complete at UWM level so we're ready for merge. Thanks.

@DeniseWorthen
Copy link
Contributor Author

@jiandewang Testing is complete at UWM so we're ready for merge.

@MatthewMasarik-NOAA
Copy link
Collaborator

Thank you @DeniseWorthen I'll merge now.

@MatthewMasarik-NOAA MatthewMasarik-NOAA merged commit b93b9f0 into NOAA-EMC:dev/ufs-weather-model Jan 4, 2023
@jiandewang
Copy link

@jiandewang Testing is complete at UWM so we're ready for merge.

MOM6 merging done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants