Add new limiter function for the implicit unstructured

[aronroland]

Pull Request Summary

Hersbach & Janssen with the motivation to reduce time step dependency for the implicit scheme when big time steps is chosen.

Description

We maximize the limiter of Komen et al. and Hersbach and Jannnsen. In the absence of wind and small time steps, the max operator between both limiter values makes sure that the limiter remains convergent (Tolman https://doi.org/10.1080/10236730290003392). When USTAR goes to zero and deltat is small, the Komen et al. limiter will lead the solution and for big time steps and significant friction velocities we retain as much as possible the max growth rate. Such implementation redues significantly the time step dependency due to the Komen et al. limiter.

new feature

Issue(s) addressed

fixed #704

Commit Message

Add a new limiter function for the implicit unstructured part.

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
• Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[JessicaMeixner-NOAA]

@aronroland any update on this draft PR? Should it be closed at this point or re-visited?

[aronroland]

Hi Jessica,
we can abort this and delete this PR. I worked further and we need to make a new pull request. Many thanks looking at this!
Cheers
Aron

[JessicaMeixner-NOAA]

@aronroland we'll look forward to the new PR when you are ready!