Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ufs wm #521

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Sync ufs wm #521

merged 9 commits into from
Nov 17, 2021

Conversation

aliabdolali
Copy link
Contributor

Pull Request Summary

The PR syncs the dev/ufs-weather-model with the latest changes in the develop including:

  • Protect a possible divide by zero in w3src4
  • MPI reproducibility fix in w3scat
  • Modify: w3wavemd.F90, w3initmd.F90 - fix for OUTID
  • Updated version number to 7.14
  • Bugfix/FLX5 Tau
  • Small bugfix to variable INTENT

Description

This PR is to make the dev/ufs-weather-model branch up to date with develop
What bug does it fix, or what feature does it add?
ufs-community/ufs-weather-model#229
ufs-community/ufs-weather-model#427

Check list

Commit Message

dev/ufs-weather-model: MPI reproducibility fix, Protect a possible divide by zero and fix for OUTID

JessicaMeixner-NOAA and others added 7 commits October 19, 2021 09:49
Use CPP ifdefs instead of switches for pre-processing and convert all code from ftn to F90 files. (ftn->src) 
The tools for converting ftn->src can be found in the model/tools directory.
bugfix: OUTID length adjusted for secondary restarts.
Bugfix/FLX5 Tau 
Small bugfix to variable INTENT
Protect a possible divide by zero ustar in w3src4
)

Update w3scat to update values of VA for MAPSTA.ne.0 which solves some mpi reproducibility issues.
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 46b3896 into NOAA-EMC:dev/ufs-weather-model Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants