Protect a possible divide by zero in w3src4 #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Bug fix for protecting a possible divide by zero in w3src4
Description
When using ST4 physics, it's possible to attempt to divide by a zero ustar. This update protects this possibility and defines a z0 value for the case if ustar=0.
Issue(s) addressed
Check list
Is your feature branch up to date with the authoritative repository (NOAA/develop)? yes
Make sure you have checked the checklist for a developer submitting to develop and updating version number no version number update
Please list appropriate labels code managers should add for this PR:
bug
Reviewers: @aliabdolali @MatthewMasarik-NOAA @ukmo-ccbunney @mickaelaccensi (anyone/everyone)
Commit Message
Testing
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
Expected not b4b diffs:
no expected code changes