Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crtm to 2.4.0 on WCOSS2 for GFS V16.3.0 Implementation #548

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Upgrade crtm to 2.4.0 on WCOSS2 for GFS V16.3.0 Implementation #548

merged 3 commits into from
Aug 19, 2022

Conversation

WenMeng-NOAA
Copy link
Collaborator

Upgrade crtm to 2.4.0 to support GFS V16.3.0 implementation.

@WenMeng-NOAA WenMeng-NOAA requested a review from aerorahul August 18, 2022 23:24
@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 18, 2022 that may be closed by this pull request
Upgrade crtm to 2.4.0 for GFS V16.3.0 Implementation #549
Closed
@WenMeng-NOAA
Copy link
Collaborator Author

Since crtm/2.4.0 is not available at the hpc-stack with intel/2018 for GFS V16 on Hera and Orion, updates for Hera and Orion will be incorporated in the future.

aerorahul
aerorahul reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module and version changes look good.
I don't think I can comment on the Fortran code changes.

Just one suggestion for a change in build_upp_lib.sh, since it will break on Hera and Orion.

aerorahul
aerorahul approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@WenMeng-NOAA WenMeng-NOAA merged commit 2fc09cc into NOAA-EMC:release/gfs_v16 Aug 19, 2022
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 19, 2022
Open
@WenMeng-NOAA WenMeng-NOAA deleted the post_crtm branch December 6, 2022 14:50
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Oct 18, 2023
@hu5970
Update workflow based on RRFS_A v0.6.1 on Cactus. (NOAA-EMC#548)
d4bde21 
Co-authored-by: ming hu <ming.hu@clogin08.cactus.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

Assignees
No one assigned
Labels
GFSV16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade crtm to 2.4.0 for GFS V16.3.0 Implementation
2 participants
@WenMeng-NOAA @aerorahul