Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bort tests, some misc tests #422

Merged
merged 3 commits into from
Mar 28, 2023
Merged

More bort tests, some misc tests #422

merged 3 commits into from
Mar 28, 2023

Conversation

edwardhartnett
Copy link
Contributor

Part of #381

These are the new bort tests from PR #415.

Also some misc tests.

@jbathegit I have fixed the segfaults in ufbstp() bort testing. That's for catching them.

This contains the tests from #415 without the documentation changes. Let's get the tests merged and doing some good while we continue to discuss documentation issues.

@edwardhartnett edwardhartnett changed the title More bort tests More bort tests, some misc tests Mar 28, 2023
@jbathegit
Copy link
Collaborator

jbathegit commented Mar 28, 2023

Thanks Ed, but I'm still seeing the aforementioned memory leaks in the test output for the developer CI run. If you pop open the details for the test step and search for ERROR: LeakSanitizer, you'll see that there are a couple of them, right between tests for upftbv case 2 and wrdxtb case 1.

@edwardhartnett
Copy link
Contributor Author

OK, stand by while I take a look. But I would expect memory leaks from test_bort, because instead of closing anything, it just aborts. ;-)

@edwardhartnett
Copy link
Contributor Author

OK, I have fixed the memory leaks.

In general, that may not always be possible, and that's OK. test_bort can leak memory, and the memory leak will cause a non-zero error code, but the script run_test_bort.sh is already expecting a non-zero return code, so it does not cause the CI testing to fail.

If memory leaks occur tests other than test_bort.F90, then they will cause CI to fail. So this is all was we wish it to be.

@jbathegit jbathegit merged commit f8e60c1 into develop Mar 28, 2023
@edwardhartnett edwardhartnett deleted the ejh_bort3 branch March 28, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants