Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we still need -DENABLE_TESTS=ON? #57

Closed
jbathegit opened this issue Nov 9, 2020 · 3 comments · Fixed by #58
Closed

do we still need -DENABLE_TESTS=ON? #57

jbathegit opened this issue Nov 9, 2020 · 3 comments · Fixed by #58

Comments

@jbathegit
Copy link
Collaborator

@edwardhartnett @aerorahul

Now that testing is enabled by default, do we still need -DENABLE_TESTS=ON in README.md (in the Installation instructions) and in .github/workflows/main.yml? It might be cleaner if we just remove these - any thoughts?
@aerorahul
Copy link
Contributor

Get rid of the option in README.md. It does not exist as an option in the build.

@jbathegit
Copy link
Collaborator Author

OK will do, but can we also remove it from .github/workflows/main.yml?

This relates to the (now closed) #19. We did enable testing by default, but we never removed -DENABLE_TESTS=ON from all of the places where this was explicitly (and now redundantly ;-) set.

@edwardhartnett
Copy link
Contributor

Yes it can be removed everywhere.

@jbathegit jbathegit mentioned this issue Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bring over last remaining WCOSS src updates, and add new test_OUT_5 program NOAA-EMC/NCEPLIBS-bufr
3 participants
@aerorahul @edwardhartnett @jbathegit