Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intel build and code coverage #42

Closed
edwardhartnett opened this issue Oct 5, 2021 · 6 comments
Closed

Add intel build and code coverage #42

edwardhartnett opened this issue Oct 5, 2021 · 6 comments
Assignees
Labels
build Building software is complicated! test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

@kgerheiser can you do this one?

@edwardhartnett edwardhartnett added test Testing is important! build Building software is complicated! labels Oct 5, 2021
@edwardhartnett
Copy link
Contributor Author

I have added code coverage...

We still need intel compiler build.

@edwardhartnett
Copy link
Contributor Author

@kgerheiser how come when I do the code coverage commands on my own system, I get a nice looking coverage report like this:

image

But when I download the artifact and open it, it looks terrible:

image

@edwardhartnett
Copy link
Contributor Author

I note that on my machine I seem to have gcovr 4.2 but our CI system is using 5.0. Perhaps that's part of the problem...

@edwardhartnett
Copy link
Contributor Author

OK, one problem is that when we upload the coverage report files, we are grabbing all html, but there is also a css file to grab! We are missing it...

@kgerheiser this will probably have to be fixed everywhere. While fixing, also include the -e ../tests argument to gcovr, to leave the test code out of the code coverage report.

@edwardhartnett
Copy link
Contributor Author

OK, adding the CSS file improves the download code coverage report:
image

So it looks better, which is nice. But it's also completely wrong. When I run it on my machine, I see a ~46% test coverage for bacio.c, which seems right, since I've just written a test which exercises that code a lot.

But when I download the coverage report, it still says 0% for bacio.c.

@edwardhartnett
Copy link
Contributor Author

OK, this was because I had ctest --version instead of ctest --verbose! Now everything is working. I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building software is complicated! test Testing is important!
Projects
None yet
Development

No branches or pull requests

2 participants