Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update how UFS names restarts #109

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

  • write all restarts as YYYYMMDD.HHMMSS.MOM.resX
  • includes stoch restarts
  • write final restart with timestamp
  • change nems=>ufs

* write all restarts as YYYYMMDD.HHMMSS.MOM.resX
* includes stoch restarts
* write final restart with timestamp
* change nems=>ufs
@jiandewang
Copy link
Collaborator

@DeniseWorthen let's work in the following orders:
(1) wait for unstructured kstokes PR being merged to main (just need one more approval, shall come early coming week)
(2) I created PR to pull it back to dev/emc (as this commit contains fixing for ci), asking Jong to give me high priority to combine it with other coming PR to merge to dev/emc
(3) you sync your branch
(4) you have UFS PR and we merge to MOM6 dev/emc
(5) push back to MOM6 main (I will coordinate with GFDL on whether it goes ahead or after their PR, it's unlikely that your PR will cause conflict)

@DeniseWorthen
Copy link
Collaborator Author

@jiandewang That all sounds fine. Thanks.

@DeniseWorthen
Copy link
Collaborator Author

@jiandewang We need approval before we start the UFS RT testing.

@DeniseWorthen
Copy link
Collaborator Author

@jiandewang We're ready for the MOM6 merge. Thanks.

@jiandewang jiandewang merged commit 520a4d1 into NOAA-EMC:dev/emc Feb 27, 2023
@jiandewang
Copy link
Collaborator

@jiandewang We're ready for the MOM6 merge. Thanks.

done

BinLiu-NOAA pushed a commit to hafs-community/MOM6 that referenced this pull request Apr 8, 2024
* Fix non-standard white space

  Made widespread corrections to indentation and other white space issues to
conform to the MOM6 standards, as documented in the white space section of the
MOM6 style guide, at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide.

- MOM6 code uses a 2-point indent scheme.

- There should be a space around all assignment (" = ") operators.

- The names of optional arguments do not use whitespace, to differentiate them
  from assignments.

- There is a space around the semicolons for stacked enddo statements.

After this change, greping for '^ [a-zA-Z]', '^   [a-zA-Z]' or '^     [a-zA-Z]'
does not find any lines in the MOM6 src or config_src/infra code.  All answers
and output are bitwise identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants