Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/gfsda.v16 #644

Merged

Conversation

ADCollard
Copy link
Contributor

This PR fixes a typo in the exglobal_atmos_analysis.sh script. NOAA-21 ATMS and CrIS were pointing to a temporary bufr files that is not present now that the data are operationally dumped.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The revised script as been tested in a single cycle and the results are as expected.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is straightforward. The OBS_INPUT namelist referenced local files atmbufr21 and crisbufr21. The script copied the ATMS and CrIS bufr dump files to local files atmsbufr and crisbufr. This PR removes the suffix 21 from local filenames in the OBS_INPUT namelist.

Approved pending peer reviews & approvals.

Copy link
Contributor

@HaixiaLiu-NOAA HaixiaLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good to go.

Copy link
Contributor

@emilyhcliu emilyhcliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADCollard Good to spot the bug. You must receive separate BUFR files containing only N21 data for testing.
Changes look good. Approved!

@RussTreadon-NOAA RussTreadon-NOAA merged commit 7fc1a3d into NOAA-EMC:release/gfsda.v16 Oct 20, 2023
@RussTreadon-NOAA
Copy link
Contributor

Recreate tag gfsda.v16.3.10. Done at 7fc1a3d.

@ADCollard
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants