Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gdasechgres namelist for new version of enkf_chgres_recenter_ncio #54

Conversation

CoryMartin-NOAA
Copy link
Contributor

Don't merge in until corresponding changes have been merged into global-workflow/feature/gfsv16b.

Changes one line of namelist generation from vcoord_file=$SIGLEVEL to ref_file to be the same as terrain_file.

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review August 25, 2020 18:09
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cory tested this minor change and found no change in results for GFS v16 DA. This change will be approved and merged when the corresponding change in GFS v16 workflow is merged.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding change for feature/gfsv16b workflow has been approved. This PR is approved. Merger into release/gfsda.v16.0.0 will take place when global-workflow PR #19 is merged into feature/gfsv16b.

@RussTreadon-NOAA RussTreadon-NOAA merged commit df2581c into NOAA-EMC:release/gfsda.v16.0.0 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants