GitHub Issue NOAA-EMC/GSI#368. WCOSS2 port. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSafford-NOAA
approved these changes
Apr 29, 2022
1526872 to
efc9ee9
Compare
There was a problem hiding this comment.
One question: Do we want this PR to change the hash for submodule fix? develop/fix is at 38c00f0. This PR changes fix to point at 6f41493. The following files differ between these two hashes
fix/global_convinfo.txt
fix/gfsv16_historical/0readme
Other changes looks good.
|
@EdwardSafford-NOAA @RussTreadon-NOAA Thanks for the review! The changes to fix are to bring in the fix file changes from the gfsda.v16.1.6 implementation. So, the update to fix is required to finally bring in these changes to develop. |
RussTreadon-NOAA
approved these changes
May 2, 2022
efc9ee9 to
845b360
Compare
|
The due date for the review committee has passed with no feedback, so final approval will be given to these changes and they will be merged to the authoritative repository. |
MichaelLueken
added a commit
that referenced
this pull request
May 27, 2022
GitHub Issue #368. WCOSS2 port.
EdwardSafford-NOAA
referenced
this pull request
in EdwardSafford-NOAA/GSI
May 27, 2022
GitHub Issue NOAA-EMC/GSI#368. WCOSS2 port.
AndrewEichmann-NOAA
referenced
this pull request
in AndrewEichmann-NOAA/GSI
Jun 6, 2022
GitHub Issue NOAA-EMC/GSI#368. WCOSS2 port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GFS v16.3 package will be the first implementation on WCOSS2. In order to facilitate the running of real time parallels, which will be required shortly, the current changes in feature/gfsda.v16.1.5_wcoss2_port will be merged into the develop branch, along with the rest of the GFS v16.3 updates.
For specific details on changes associated with this work, please see issues #246 and #298.
Closes #368