-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/gfsda.v16.x #210
Release/gfsda.v16.x #210
Conversation
0d004ac
to
2362c52
Compare
Linked issue #213 |
@LouisKouvaris-NOAA I just saw this PR by explicitly searching for it on github. For some reason, I did not get automatic notification about reviewing this PR. Does everyone else get notification about reviewing this PR? |
@LouisKouvaris-NOAA Thank you for making efforts to finish this. The changes look good to me. I will approve after the following comments are addressed. 1, Please run 2 stand-alone tests. One is the default which has ompslp_mult_fact=2.0 and the other uses ompslp_mult_fact /= 2.0 and compare if the analysis results are different (compare gsistat file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go!
I ran regression test against the release/gfsda.v16.x and the failed results are in /scratch1/NCEPDEV/da/Louis.Kouvaris/noscrub/regression. Only two failures, global_T62_ozonly_regression which is expected and global_T62_regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the caveat that I will make an additional merge afterwards fixing the noted typo. This is likely the easiest path since Louis has retired and cannot update his PR.
Added new OMPS NM QC
Added the top five layers in OMPS NP
Added monitoring OMPS NP N20
global_ozinfo.txt