Feature/gdaschgres #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to 4 spaces instead of 2 to conform to Python coding norms for calcanl_gfs.py; removed capability to run chgres in calcanl_gfs.py; add print statements to gsi_utils for link, copy, mkdir; create chgres ex script from analcalc
CoryMartin-NOAA
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Works for me, @RussTreadon-NOAA. Might want to ask someone else for an independent review who didn't write any of the code.
|
Thanks, Cory, for the quick review. Additional work remains in release/gfsda.v16.0.0. Eventually release/gfsda.v16.0.0 will be merged back into master (later to be renamed "develop"). Given this, I'll merge based on your review and my working with your changes. Doing so allows GFS v16 parallels to quickly update to the refactored workflow. |
|
@RussTreadon-NOAA ok sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor DA workflow by moving chgres operation in JGLOBAL_ANALCALC to a new job, JGDAS_ENKF_CHGRES. Refactoring does not alter cycled results. Cycled tests on WCOSS_D (Mars) and Hera confirm no change result.
PR opened to merge workflow updates in CoryMartin-NOAA/GSI branch feature/gdaschgres into NOAA-EMC/GSI branch release/gfsda.v16.0.0.