Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue 194. Update RadMon fix files, correct html errors. #197

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

EdwardSafford-NOAA
Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA commented Aug 11, 2021

This pull request completes issue #194.

  • update MkBase.sh utility
  • fix 2 html errors
  • update fix files for recent changes in sat/instruments

@MichaelLueken-NOAA this is all set, thanks.

@MichaelLueken
Copy link
Contributor

@EdwardSafford-NOAA Would you like anyone to review your changes, or can I safely move forward with merging these to the authoritative repo?

@EdwardSafford-NOAA
Copy link
Contributor Author

@MichaelLueken-NOAA These changes can be merged to the authoritative repo. The changes are quite minor and the important ones (the fix file updates) have been used by the RadMon to process the operational GDAS for a few days now with no problems.

@MichaelLueken MichaelLueken linked an issue Aug 11, 2021 that may be closed by this pull request
@MichaelLueken
Copy link
Contributor

The changes were cloned, compiled, and the regression tests (both standard and debug) were run. All passed successfully. Since there are no source code changes in this update, I will now give final approval and merge this work to the authoritative repo.

@MichaelLueken MichaelLueken merged commit e306315 into NOAA-EMC:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RadMon and fix html issue
2 participants