Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace src/fv3gfs_ncio with hpc-stack built ncio library #320

Closed
MichaelLueken opened this issue Mar 2, 2022 · 3 comments
Closed

Replace src/fv3gfs_ncio with hpc-stack built ncio library #320

MichaelLueken opened this issue Mar 2, 2022 · 3 comments
Assignees
@MichaelLueken

Comments

@MichaelLueken
Copy link
Contributor

Work to replace src/fv3gfs_ncio with the hpc-stack built ncio library will be done in the feature/fv3gfs_ncio-removal branch.
@MichaelLueken MichaelLueken self-assigned this Mar 2, 2022
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 17, 2022
@MichaelLueken
GitHub Issue NOAA-EMC/GSI#320. Replaced fv3gfs_ncio with hpc-stack bu…
7024960 
…ilt ncio.

 * all CMakeLists.txt entries that use fv3gfs_ncio - updated to use hpc-stack built ncio library
 * cmake/Modules/setGNUFlags.cmake - remove fv3gfs_ncio flags
 * cmake/Modules/setIntelFlags.cmake - same
 * hpc-stack compliant modulefiles - add module load ncio/1.0.0
 * src/fv3gfs_ncio - removed
 * all *90 which currently use module_fv3gfs_ncio - replace module_fv3gfs_ncio with module_ncio
@MichaelLueken
Copy link
Contributor Author

In 7024960:

  • CMakeLists.txt entries that use fv3gfs_ncio - updated to use hpc-stack built ncio library
  • cmake/Modules/setGNUFlags.cmake - remove fv3gfs_ncio flags
  • cmake/Modules/setIntelFlags.cmake - same
  • hpc-stack compliant modulefiles - add module load ncio/1.0.0
  • src/fv3gfs_ncio - removed
  • all *90 which currently use module_fv3gfs_ncio - replace module_fv3gfs_ncio with module_ncio

The code compiled without issue (both standard and debug) and the regression tests passed successfully on Venus. Testing on Hera will now commence.

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 21, 2022
@MichaelLueken
GitHub Issue NOAA-EMC/GSI#320. Replaced fv3gfs_ncio with hpc-stack bu…
b02ffbc 
…ilt ncio.

 * all CMakeLists.txt entries that use fv3gfs_ncio - updated to use hpc-stack built ncio library
 * cmake/Modules/setGNUFlags.cmake - remove fv3gfs_ncio flags
 * cmake/Modules/setIntelFlags.cmake - same
 * hpc-stack compliant modulefiles - add module load ncio/1.0.0
 * src/fv3gfs_ncio - removed
 * all *90 which currently use module_fv3gfs_ncio - replace module_fv3gfs_ncio with module_ncio
 * ush/sub_hera - corrected issue that would cause regression tests to fail on Hera due to SLURM out-of-memory issues
@MichaelLueken
Copy link
Contributor Author

In b02ffbc:

  • ush/sub_hera - corrected issue that would cause regression tests to fail on Hera due to SLURM out-of-memory issues

The code compiles and runs on Hera. The regression tests all successfully passed (following the minor addition to ush/sub_hera in this update).

@MichaelLueken MichaelLueken mentioned this issue Mar 21, 2022
Closed
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 22, 2022
@MichaelLueken
GitHub Issue NOAA-EMC/GSI#320. Replaced fv3gfs_ncio with hpc-stack bu…
2db5d3c 
…ilt ncio.

 * all CMakeLists.txt entries that use fv3gfs_ncio - updated to use hpc-stack built ncio library
 * cmake/Modules/setGNUFlags.cmake - remove fv3gfs_ncio flags
 * cmake/Modules/setIntelFlags.cmake - same
 * hpc-stack compliant modulefiles - add module load ncio/1.0.0
 * src/fv3gfs_ncio - removed
 * all *90 which currently use module_fv3gfs_ncio - replace module_fv3gfs_ncio with module_ncio
 * ush/sub_hera - corrected issue that would cause regression tests to fail on Hera due to SLURM out-of-memory issues
@MichaelLueken MichaelLueken mentioned this issue Apr 1, 2022
Merged
@MichaelLueken
Copy link
Contributor Author

Closing issue, since work in PR #327 supersedes this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelLueken MichaelLueken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Issue NOAA-EMC/GSI#320. Replaced fv3gfs_ncio with hpc-stack built ncio. MichaelLueken/GSI
1 participant
@MichaelLueken