Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Correlated Error Code #212

Closed
KristenBathmann opened this issue Sep 20, 2021 · 2 comments · Fixed by #217
Closed

Updates to Correlated Error Code #212

KristenBathmann opened this issue Sep 20, 2021 · 2 comments · Fixed by #217
Assignees
@KristenBathmann

Comments

@KristenBathmann
Copy link
Contributor

Currently the correlated error code in the GSI src code cannot handle inconsistencies between the satinfo and the channels specified in a provided covariance file. This update will fix this, deleting row/columns in the covariance matrx if a channel is removed from the satinfo, or adding a row and column with no correlations if a channel is turned on in the satinfo. The changes will only occur in the initial setup routine of the correlated_obsmod, and no changes to runtime are expected.
KristenBathmann added a commit to KristenBathmann/GSI that referenced this issue Sep 28, 2021
@KristenBathmann
GitHub Issue NOAA-EMC/GSI#212 updates to correlated error code
a5e2edf
@KristenBathmann
Copy link
Contributor Author

Regression tests have passed, as expected. The only failure was global_fv3_4denvar_C192, but it was because of memory use. There were no differences between the control and update.

@CatherineThomas-NOAA CatherineThomas-NOAA linked a pull request Oct 8, 2021 that will close this issue
GitHub Issue NOAA-EMC/GSI#212 updates to correlated error code #217
Merged
CatherineThomas-NOAA added a commit that referenced this issue Oct 8, 2021
@CatherineThomas-NOAA
Merge pull request #217 from KristenBathmann-NOAA/release/gfsda.v16.x
de4c91b 
GitHub Issue #212 updates to correlated error code
@CatherineThomas-NOAA
Copy link
Collaborator

Merged to the v16.x release branch at de4c91b. Closing issue.

@CatherineThomas-NOAA CatherineThomas-NOAA mentioned this issue Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristenBathmann KristenBathmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Issue NOAA-EMC/GSI#212 updates to correlated error code KristenBathmann/GSI
2 participants
@KristenBathmann @CatherineThomas-NOAA