-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 4D variables in getsfcensmeanp.x
utility.
#4
Conversation
getsfcensmeanp does not handle 4D variables. skip them
Please add @emilyhcliu as a reviewer since this involves |
@aerorahul and @emilyhcliu , I propose a different fix. I added logic to |
@RussTreadon-NOAA |
@aerorahul , you ask excellent questions which bounce back to the modeling team (@yangfanglin , @junwang-noaa ). For the time being I will add my change to your branch, |
@aerorahul , I am unable to push commits to github.
|
Please see comments I made in NOAA-EMC/global-workflow#902 |
getsfcensmeanp.x
utility.getsfcensmeanp.x
utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discuss various paths forward with @aerorahul . For the sake of timeliness, decide to move forward with this PR. A follow up PR can be opened at a later date based on @emilyhcliu's feedback.
getsfcensmeanp can now handle 4D variables.
Specifically,
cldfra
was introduced by the UFS-weather-model.Any/all 4D variables will be averaged in the
sfc
files.See commit f1dc784 that adds ability to process 4D variables.