-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate multi-cycle concatination and separation of variables in post-BUFR observations #1504
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obs spaces for insitu temp and salt are not setup correctly. I added links to simple examples from the soca repo for guidance.
Automated GW-GDASApp Testing Results:
|
The last CI seems to have been started before the latest commits (particularly to |
Automated GW-GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good-
8975174
Does this need any more changes? |
Let me quickly check one more time- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 minor thing @AndrewEichmann-NOAA
…DASApp into feature/insitu-concat
1cf85fb
Description
Tested with
C48mx500_3DVarAOWCDA
andC48mx500_hybAOWCDA
on Hera with NOAA-EMC/jcb-gdas#78 and obs spaces enabled inOBS_LIST
. Aside from passing test, filesgdas.t00z.insitu_salt_profile_argo.2021032500.nc4
andgdas.t00z.insitu_temp_profile_argo.2021032500.nc4
are delivered togdas.20210325/00/obs
bearing plausible-looking values for salt and temperature respectively, and seem to be assimilated. No quantitative analysis has been performed on these obs.Companion PRs
Not necessary for merging and passing ctests, but if new obs spaces get included the following is needed:
NOAA-EMC/jcb-gdas#78
Issues
Mostly resolves #1132
Automated CI tests to run in Global Workflow