Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate multi-cycle concatination and separation of variables in post-BUFR observations #1504

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Feb 20, 2025

Description

  • Implements modifications to concatinate IODA observation files converted from BUFR format from multiple cycles in a window to a single file for the current cycle
  • Separates temperature from salinity observations in Argo floats so that they are delivered to obs under COMROOT as two separate IODA files

Tested with C48mx500_3DVarAOWCDA and C48mx500_hybAOWCDA on Hera with NOAA-EMC/jcb-gdas#78 and obs spaces enabled in OBS_LIST. Aside from passing test, files gdas.t00z.insitu_salt_profile_argo.2021032500.nc4 and gdas.t00z.insitu_temp_profile_argo.2021032500.nc4 are delivered to gdas.20210325/00/obs bearing plausible-looking values for salt and temperature respectively, and seem to be assimilated. No quantitative analysis has been performed on these obs.

Companion PRs

Not necessary for merging and passing ctests, but if new obs spaces get included the following is needed:
NOAA-EMC/jcb-gdas#78

Issues

Mostly resolves #1132

Automated CI tests to run in Global Workflow

  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obs spaces for insitu temp and salt are not setup correctly. I added links to simple examples from the soca repo for guidance.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Feb 21, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 21, 2025
@emcbot
Copy link

emcbot commented Feb 21, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Fri Feb 21 20:12:59 UTC 2025 on hfe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Feb 21 20:58:03 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                  *Failed*
Tests: Failed at Fri Feb 21 23:47:07 UTC 2025
Tests: 84% tests passed, 9 tests failed out of 56
	2044 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlinit_202103250000 (Failed)
	2045 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2046 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2047 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
	2055 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlletkf_202103250000 (Failed)
	2056 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlinit_202103250000 (Failed)
	2057 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2059 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2060 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1504/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 21, 2025
@AndrewEichmann-NOAA
Copy link
Collaborator Author

The last CI seems to have been started before the latest commits (particularly to obs_list)

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Feb 24, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 24, 2025
@emcbot
Copy link

emcbot commented Feb 24, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Mon Feb 24 15:45:02 UTC 2025 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Feb 24 16:29:13 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Mon Feb 24 17:04:28 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 56

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 24, 2025
apchoiCMD
apchoiCMD previously approved these changes Feb 24, 2025
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good-

apchoiCMD
apchoiCMD previously approved these changes Feb 25, 2025
@AndrewEichmann-NOAA
Copy link
Collaborator Author

Does this need any more changes?

@apchoiCMD
Copy link
Collaborator

Does this need any more changes?

Let me quickly check one more time-

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 minor thing @AndrewEichmann-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
5 participants