From 14935c2c8a925ddf7ff70bdfd0890cdef4b318fa Mon Sep 17 00:00:00 2001 From: Rolf Kristensen Date: Mon, 30 Aug 2021 20:11:26 +0200 Subject: [PATCH] NLogLoggerProvider - Always load from appsettings when possible (#529) --- .../Extensions/ConfigureExtensions.cs | 9 +++------ .../Extensions/ConfigureExtensions.cs | 6 +----- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs b/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs index 2a6a2e86..0cb65aae 100644 --- a/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs +++ b/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs @@ -48,17 +48,14 @@ private static void AddNLogLoggerProvider(IServiceCollection services, IConfigur private static NLogLoggerProvider CreateNLogLoggerProvider(IServiceProvider serviceProvider, IConfiguration configuration, NLogProviderOptions options) { - configuration = SetupConfiguration(serviceProvider, configuration); NLogLoggerProvider provider = new NLogLoggerProvider(options); + configuration = SetupConfiguration(serviceProvider, configuration); if (configuration != null) { - if (options == null) - { - provider.Configure(configuration.GetSection("Logging:NLog")); - } - + provider.Configure(configuration.GetSection("Logging:NLog")); provider.TryLoadConfigurationFromSection(configuration); } + return provider; } diff --git a/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs b/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs index 74710a82..52d482fc 100644 --- a/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs +++ b/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs @@ -252,11 +252,7 @@ private static NLogLoggerProvider CreateNLogLoggerProvider(IServiceProvider serv configuration = SetupConfiguration(serviceProvider, configuration); if (configuration != null) { - if (options == null) - { - provider.Configure(configuration.GetSection("Logging:NLog")); - } - + provider.Configure(configuration.GetSection("Logging:NLog")); provider.TryLoadConfigurationFromSection(configuration); }