Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make distinction between root finding algorithm and function clearer #29

Closed
sverhoeven opened this issue Jun 2, 2020 · 2 comments
Closed

Make distinction between root finding algorithm and function clearer #29

sverhoeven opened this issue Jun 2, 2020 · 2 comments
Assignees
@fdiblen
Labels
good first issue Good for newcomers
Milestone
v1.0.0

Comments

@sverhoeven
Copy link
Member

At the moment the x^3 - x^2 + 2 function and its derivative are hard to distinguish from the root finding algorithm. It would be nice if the function + derivative could be moved to their own code block
So it is clearer we are trying to find the root of the x^3 - x^2 + 2 function with the Newton-Raphson algorithm.
@sverhoeven sverhoeven added this to the v1.0.0 milestone Jun 2, 2020
@sverhoeven sverhoeven added the good first issue Good for newcomers label Jun 2, 2020
@sverhoeven sverhoeven modified the milestone: v1.0.0 Jun 3, 2020
@sverhoeven
Copy link
Member Author

And rename func to equation and derivFunc to derivative.

@sverhoeven sverhoeven mentioned this issue Jun 3, 2020
Merged
@fdiblen fdiblen self-assigned this Jun 3, 2020
@fdiblen
Copy link
Collaborator

fdiblen commented Jun 4, 2020

also rename find to solve.

@fdiblen fdiblen mentioned this issue Jun 4, 2020
Merged
@fdiblen fdiblen closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fdiblen fdiblen

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@fdiblen @sverhoeven