Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize crown area weighted height history diagnostic #1170

Closed
rgknox opened this issue Mar 13, 2024 · 0 comments · Fixed by #1174
Closed

normalize crown area weighted height history diagnostic #1170

rgknox opened this issue Mar 13, 2024 · 0 comments · Fixed by #1174

Comments

@rgknox
Copy link
Contributor

rgknox commented Mar 13, 2024

The calculation of crown area weighted canopy height is not complete. It needs to be normalized by total crown area of all cohorts participating in the site level sum. Here is where we accumulate the mean height:

https://github.com/NGEET/fates/blob/sci.1.72.1_api.33.0.0/main/FatesHistoryInterfaceMod.F90#L3604-L3605

There needs to be a sum of crown area, and division through by that area, following the cohort/patch loop.

@rgknox rgknox changed the title normalize crown area weighted height normalize crown area weighted height history diagnostic Mar 13, 2024
@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant