Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Rebuild Basic Search Form #344

Open
1 of 4 tasks
Tracked by #405
arcepaul opened this issue Sep 30, 2021 · 0 comments
Open
1 of 4 tasks
Tracked by #405

[META] Rebuild Basic Search Form #344

arcepaul opened this issue Sep 30, 2021 · 0 comments
Labels
meta Meta rollup issue

Comments

@arcepaul
Copy link
Contributor

arcepaul commented Sep 30, 2021

NOTE: This ticket was previously a list of what we need to do to retrofit the current search pages with React Hook Form. This was not going to be possible to iteratively replace elements due to the current search controls.

This meta ticket is to roll up all the tasks to implement the Basic Search Form. Additionally, the initial setup of the Search Form will set the ground work for implementing the Advanced Search Form. This will be a ground up build of the form. None of the search components or atomic components they reference should be used. (Unless they are 100% free of Redux and side effects) However, the low-level markup (input, label, etc) used to render the controls and the validation logic should be leveraged from the existing search controls.

In order to start on this all the Basic Search Integration tests need to be commented out. They will then be slowly uncommented as the code is updated so they may pass. @kate-mashkina please add any additional information here.

NOTE: This should be done in a feature branch. in creating the form, this allows the individual components to be worked on separately and just get registered when added to the form

Initial Form Setup

@arcepaul arcepaul added the story label Sep 30, 2021
@sarinapadilla sarinapadilla changed the title Implement React-Form on search page [META] Implement React-Form on search page Oct 26, 2021
@bryanpizzillo bryanpizzillo added meta Meta rollup issue and removed story labels Oct 28, 2021
@bryanpnih bryanpnih changed the title [META] Implement React-Form on search page [META] Rebuild Basic Search Form Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta rollup issue
Projects
None yet
Development

No branches or pull requests

2 participants