Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#28 #83

Merged
merged 13 commits into from
Jan 23, 2023
Merged

UFS-dev PR#28 #83

merged 13 commits into from
Jan 23, 2023

Conversation

grantfirl
Copy link
Collaborator

Identical to ufs-community#1522

Requires new baselines, but not for the CCPP code changes. The new baselines are required for ufs-community#1527. I think that this should only be for tests with WW3 active?

DusanJovic-NOAA and others added 7 commits December 23, 2022 16:05
@DusanJovic-NOAA @binli2337
@BrianCurtis-NOAA @jkbk2004
Convert all regression tests to use ESMF managed threading (ufs-commu…
5c5827d 
…nity#1523)

* Convert all regression tests to use esmf-managed threading

* update CMakeLists.txt

* update rt.conf

* Comment out unneeded steps in workflows/aux.yml

* turn off control_c384 on cheyenne: all others passed

Co-authored-by: Bin.Li <bin.li@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
@DusanJovic-NOAA @BrianCurtis-NOAA @jkbk2004
Add optional 'time_unlimited' logical flag to model_configure (ufs-co…
92d2d43 
…mmunity#1535)

* allow option no updated sub-components

* Run control_c384 and control_c384gdas tests on Gaea using TPN=18

Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
@jkbk2004
clean up gitaction yml (ufs-community#1552)
5d66bca 
* clean up gitaction yml

* Update build_test.yml, aux.yml
@DeniseWorthen @BrianCurtis-NOAA @jkbk2004
use ungridded dimensions for stokes drift exchange (ufs-community#1527)
2b99f09 
* fix fd_nems.yaml

* cmeps restart will appear as different because field names changes

* set TPN=18 on cheyenne: cpld_control_c192_p8, cpld_restart_c192_p8, hafs_global_multiple_4nests_atm

Co-authored-by: Brian Curtis <Brian.Curtis@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
@BrianCurtis-NOAA @jkbk2004
MYNNsfc uniform real kind (ufs-community#1522)
a0bbece 
* MYNNsfc uniform real kind

Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Co-authored-by: jkbk2004 <jong.kim@noaa.gov>
Merge commit 'a0bbec' into ufs-dev-PR28
c3eac0b
update .gitmodules for testing
952a934
@grantfirl grantfirl requested a review from dustinswales January 9, 2023 22:31
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230117200017/ufs-weather-model
[RT] Error: Test cpld_control_p8 046 failed in check_result failed
[RT] Error: Test cpld_control_p8 046 failed in run_test failed
[RT] Error: Test cpld_debug_p8 048 failed in check_result failed
[RT] Error: Test cpld_debug_p8 048 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230117201517/ufs-weather-model
[RT] Error: Test cpld_control_p8_mixedmode 001 failed in check_result failed
[RT] Error: Test cpld_control_p8_mixedmode 001 failed in run_test failed
[RT] Error: Test cpld_control_gfsv17 002 failed in check_result failed
[RT] Error: Test cpld_control_gfsv17 002 failed in run_test failed
[RT] Error: Test cpld_control_p8 003 failed in check_result failed
[RT] Error: Test cpld_control_p8 003 failed in run_test failed
[RT] Error: Test cpld_2threads_p8 005 failed in check_result failed
[RT] Error: Test cpld_2threads_p8 005 failed in run_test failed
[RT] Error: Test cpld_esmfthreads_p8 006 failed in check_result failed
[RT] Error: Test cpld_esmfthreads_p8 006 failed in run_test failed
[RT] Error: Test cpld_decomp_p8 007 failed in check_result failed
[RT] Error: Test cpld_decomp_p8 007 failed in run_test failed
[RT] Error: Test cpld_mpi_p8 008 failed in check_result failed
[RT] Error: Test cpld_mpi_p8 008 failed in run_test failed
[RT] Error: Test cpld_control_ciceC_p8 009 failed in check_result failed
[RT] Error: Test cpld_control_ciceC_p8 009 failed in run_test failed
[RT] Error: Test cpld_control_c192_p8 010 failed in check_result failed
[RT] Error: Test cpld_control_c192_p8 010 failed in run_test failed
[RT] Error: Test cpld_bmark_p8 012 failed in check_result failed
[RT] Error: Test cpld_bmark_p8 012 failed in run_test failed
[RT] Error: Test cpld_control_noaero_p8 014 failed in check_result failed
[RT] Error: Test cpld_control_noaero_p8 014 failed in run_test failed
[RT] Error: Test cpld_debug_p8 016 failed in check_result failed
[RT] Error: Test cpld_debug_p8 016 failed in run_test failed
[RT] Error: Test cpld_debug_noaero_p8 017 failed in check_result failed
[RT] Error: Test cpld_debug_noaero_p8 017 failed in run_test failed
Please make changes and add the following label back: hera-intel-RT

@dustinswales
Copy link
Collaborator

dustinswales commented Jan 19, 2023 •
edited
Loading

@grantfirl Looks like these tests are failing, as expected, when comparing to the mediator restart files:
[Dustin.Swales@hfe07 ufs-weather-model]$ grep "NOT OK" /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230117201517/ufs-weather-model/tests/RegressionTests_hera.intel.log
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-43200.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK

Cheyenne is down this week for maintenance, should we wait to run? or skip?

@dustinswales

This comment was marked as resolved.

Sign in to view
@dustinswales

This comment was marked as resolved.

Sign in to view
@dustinswales
Copy link
Collaborator

@grantfirl Can you update the BL_DATE? (I see we made the classic mistake with the first BL_DATE of the year. Let's do 2023 for this one)

@grantfirl
Copy link
Collaborator Author

@grantfirl Looks like these tests are failing, as expected, when comparing to the mediator restart files: [Dustin.Swales@hfe07 ufs-weather-model]$ grep "NOT OK" /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230117201517/ufs-weather-model/tests/RegressionTests_hera.intel.log Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-43200.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK

Cheyenne is down this week for maintenance, should we wait to run? or skip?

I would say skip it because it has already been tested on Cheyenne in the ufs/dev branch. Hera should be good enough for our "verification" RTs for the main branch this time around.

[AutoRT] hera.gnu Job Completed.
dd953cf 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230119184515/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230119200530/ufs-weather-model
Please make changes and add the following label back: hera-gnu-BL

[AutoRT] hera.intel Job Completed.
bb4bfd5 
on-behalf-of @NCAR <dswales@ucar.edu>
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230119190013/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1191546892/20230119202728/ufs-weather-model
Please make changes and add the following label back: hera-intel-BL

@grantfirl grantfirl merged commit 258e089 into NCAR:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinswales dustinswales dustinswales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grantfirl @dustinswales @DusanJovic-NOAA @jkbk2004 @DeniseWorthen