Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check some formatting issues on NCL_sat_3.py #566

Closed
kafitzgerald opened this issue Nov 15, 2023 · 2 comments · Fixed by #571
Closed

Check some formatting issues on NCL_sat_3.py #566

kafitzgerald opened this issue Nov 15, 2023 · 2 comments · Fixed by #571
Assignees
Labels
bug Something isn't working

Comments

@kafitzgerald
Copy link
Collaborator

kafitzgerald commented Nov 15, 2023

Describe the bug
NCL_sat_3.py could use some attention.

https://geocat-examples.readthedocs.io/en/latest/gallery/MapProjections/NCL_sat_3.html

Expected behavior

  • Outline surrounding the full plot
  • Better looking colorbar ticks (or at least not inconsistent ones)
  • Better looking RHS labels (though this may be part of the NCL replication)

Screenshots
Screen Shot 2023-11-15 at 2 05 55 PM

@kafitzgerald
Copy link
Collaborator Author

kafitzgerald commented Nov 28, 2023

Sounds like this (the weird ticks on the colorbar) is a broader issue in chatting w/ Anissa. Might take a look a little sooner to better understand what's going on.

@kafitzgerald
Copy link
Collaborator Author

It looks like the contour plots now (not sure when this started) have minor ticks on the colorbars that align with the discrete colormap from the contouring.

It's not really clear to me why these examples plots are contoured in the first place and I think this problem really stems from us using some of the matplotlib functionality in a way it wasn't really intended, but 🤷🏻‍♀️.

These minor ticks can be turned off though so that's probably the easy fix for the colorbar tick issue. Unfortunately it doesn't appear to just be a parameter we can pass so it's a little more code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant