GF CU scheme in CCPP #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: gmtb_scm_type_defs.f90
modified: ccpp-framework modified: ccpp-physics
modified: ccpp-physics
|
This PR is related to the following PRs: |
This was referenced Jun 18, 2018
climbfuji
suggested changes
Aug 9, 2018
There was a problem hiding this comment.
This PR must be updated to the latest version of the code, including cross-references to the other repositories. GFS_typedefs.F90 is now part of gmtb-scm and most likel must receive the same updates for additional variables than GFS_typedefs.F90 in FV3. Also, it seems like for gmtb-scm you are requesting fewer variables than for FV3?
|
Hi Dom,
Thank you very much for your comments. I followed the way of ruc_lsm using
CCPP_OPTION_A as Tanya. We may need to get together to talk about this.
Thanks again.
Best Wishes
Haiqin
…On Thu, Aug 9, 2018 at 11:07 AM, Dom Heinzeller ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This PR must be updated to the latest version of the code, including
cross-references to the other repositories. GFS_typedefs.F90 is now part of
gmtb-scm and most likel must receive the same updates for additional
variables than GFS_typedefs.F90 in FV3. Also, it seems like for gmtb-scm
you are requesting fewer variables than for FV3?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ak4AOItnQ0C5SWk_cla13vMN1i-I_t0aks5uPGw6gaJpZM4Usoo->
.
|
|
We should (tomorrow?) - option A is only meant to facilitate development and debugging, option B is what is needed in the end. Apologies if this was not made clear to you! |
|
Hi Dom,
Sure, please call the meet tomorrow. Thanks for your explanations.
Best Wishes
Haiqin
…On Thu, Aug 9, 2018 at 11:54 AM, Dom Heinzeller ***@***.***> wrote:
We should (tomorrow?) - option A is only meant to facilitate development
and debugging, option B is what is needed in the end. Apologies if this was
not clear to you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Ak4AOGCFEoPkcRm67F6U4J0aZSZE8wwbks5uPHdQgaJpZM4Usoo->
.
|
This was referenced Oct 5, 2018
|
Closing this, will be replaced by a new PR after the FV3 version is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1). scm/src/gmt_scm_type_defs.f90
Define the dynamical forcing forcet, forceq and standard long names.