32-bit physics in FV3_RAP #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysics in single precision
…/rrtmgp_sw_cloud_sampling.F90 to support single precision builds
This was referenced May 30, 2022
This was referenced Jun 24, 2022
|
Looks fine. Approved. |
DusanJovic-NOAA
approved these changes
Jun 30, 2022
barlage
reviewed
Jul 1, 2022
physics/module_sf_noahmplsm.f90
Outdated
| @@ -10823,6 +10823,7 @@ real*8 function zolri(ri,za,z0,zt,zol1,psi_opt) | |||
| real (kind=kind_phys) :: x1,x2,fx1,fx2 | |||
| integer :: n | |||
| integer, parameter :: nmax = 20 | |||
| real(kind=kind_phys) rphys_temp | |||
There was a problem hiding this comment.
@SamuelTrahanNOAA for clarity, can you change this to something like rphys_dummy or rphys_temporary? at first, I was trying to figure out how this was a temperature.
it might be even more clear to name this variable zolri_iteration and the one below as zolrib_iteration or something similar.
There was a problem hiding this comment.
Much better names. I just made that change.
|
I've merged #1192 to this branch, and both the hera.intel and hera.gnu tests still pass. The results of the new 32-bit physics tests don't change, nor do the existing tests. These tests also included the variable name change suggested in one of the comments. |
grantfirl
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. The 64-bit physics should not change results. See #923 for past conversation and ufs-community/ufs-weather-model#1215 for the top-level PR.
About half of these changes come from @DusanJovic-NOAA, and a little bit from @climbfuji and @grantfirl. The work is based on a similar project by @michalakes in the NRL Neptune model, which also uses CCPP.
Issues
ufs-community/ufs-weather-model#1288
Dependencies
earth-system-radiation/rte-rrtmgp#180this was already merged