Remove optional arguments from CCPP metadata, remove effective radii computation from Thompson MP wrapper

[climbfuji]

Description

1. Remove optional attributes from all CCPP metadata files.

2. Remove optional and unused effective radii calculation in Thompson MP wrapper (mp_thompson.{F90,meta}). The effective radii calculation happens in the radiation interstitials, the code in the Thompson MP wrapper was not used.

Associated PRs

NCAR/ccpp-framework#408
earth-system-radiation/rte-rrtmgp#143
#763
NOAA-EMC/fv3atm#415
ufs-community/ufs-weather-model#887
SCM PR MISSING

For regression testing with the UFS, see ufs-community/ufs-weather-model#887.

[gthompsnWRF]

@climbfuji I will look over this PR, but at first glance it says 118 files were changed - sounds massive.

[climbfuji]

@climbfuji I will look over this PR, but at first glance it says 118 files were changed - sounds massive.

Yes - removing two of the four options for calling the actual microphysics from the wrapper (by removing the option to compute cloud effective radii in the wrapper), which is something that we both wanted - having to change for nearly identical calls to the actual microphysics code each time an argument is changed is unnecessary extra work. The git diff view is really poor, best to checkout old and new code and use meld or a similar tool to compare.

[dustinswales]

@climbfuji
Looks fine to me, at least the trivial (and tedious) changes to the GP schemes .meta files.
Thanks for doing this.

[climbfuji]

@climbfuji I will look over this PR, but at first glance it says 118 files were changed - sounds massive.

Yes - removing two of the four options for calling the actual microphysics from the wrapper (by removing the option to compute cloud effective radii in the wrapper), which is something that we both wanted - having to change for nearly identical calls to the actual microphysics code each time an argument is changed is unnecessary extra work. The git diff view is really poor, best to checkout old and new code and use meld or a similar tool to compare.

@gthompsnWRF to speed up the commit process, this PR has been combined with another PR into #766

All changes in the Thompson MP wrapper Fortran code are from this original PR. It would be nice if you could review either this original PR or #766, whichever you want. We are hoping to merge the changes this week, if possible. Thanks very much in advance!

[gthompsnWRF]

It's obviously too late for my comment since the code has been merged, but the simplification of calling the gt_driver subroutine with the difference between aerosol-aware and older one-moment cloud water schemes and not dealing with the radiative effective size is something I advocated for previously. So this is a good step in my opinion to simplify things. Clearly I did not review a single other part of the PR since I just assume Dom knows what he's doing on all that.

Thank you Dom and sorry it took me a while even to glance at this PR!!

[climbfuji]

Greg, thanks very much for looking at it, better late than never. Sorry we couldn't wait.